Re: [PATCH] libgccjit: Support signed char flag

2024-11-20 Thread David Malcolm
On Thu, 2024-02-22 at 15:29 -0500, Antoni Boucher wrote: > Thanks for the review and idea. Thanks for the updated patch; sorry about the delay in reviewing. > > Here's the updated patch. I added a test, but I could not set - > fsigned- > char as this is not an option accepted by the jit frontend

Re: [PATCH] libgccjit: Support signed char flag

2024-02-22 Thread Antoni Boucher
Thanks for the review and idea. Here's the updated patch. I added a test, but I could not set -fsigned- char as this is not an option accepted by the jit frontend. However, the test still works in the sense that it fails without this patch and passes with it. I'm just wondering if it would pass on

Re: [PATCH] libgccjit: Support signed char flag

2024-01-09 Thread David Malcolm
On Thu, 2023-12-21 at 08:42 -0500, Antoni Boucher wrote: > Hi. > This patch adds support for the -fsigned-char flag. Thanks. The patch looks correct to me. > I'm not sure how to test it since I stumbled upon this bug when I > found > this other bug (https://gcc.gnu.org/bugzilla/show_bug.cgi?id=1