Re: [PATCH] libgccjit: Allow comparing aligned int types

On Thu, 2024-02-22 at 12:40 -0500, Antoni Boucher wrote: > Thanks for the review. > Here's the updated patch. Thanks; the updated patch is good for trunk. Dave > > On Wed, 2024-01-24 at 12:18 -0500, David Malcolm wrote: > > On Thu, 2023-12-21 at 08:33 -0500, Antoni Boucher wrote: > > > Hi. > >

Re: [PATCH] libgccjit: Allow comparing aligned int types

Thanks for the review. Here's the updated patch. On Wed, 2024-01-24 at 12:18 -0500, David Malcolm wrote: > On Thu, 2023-12-21 at 08:33 -0500, Antoni Boucher wrote: > > Hi. > > This patch allows comparing aligned integer types as equal. > > There's a TODO in the code about whether we should check t

Re: [PATCH] libgccjit: Allow comparing aligned int types

On Thu, 2023-12-21 at 08:33 -0500, Antoni Boucher wrote: > Hi. > This patch allows comparing aligned integer types as equal. > There's a TODO in the code about whether we should check that the > alignment is equal. > What are your thoughts on this? I think we should check for equal alignment. [..

Re: [PATCH] libgccjit: Allow comparing aligned int types

David: Ping. On Thu, 2023-12-21 at 08:33 -0500, Antoni Boucher wrote: > Hi. > This patch allows comparing aligned integer types as equal. > There's a TODO in the code about whether we should check that the > alignment is equal. > What are your thoughts on this? > > Thanks for the review.