Re: [PATCH] libgccjit: Add support for bitcasts [PR104071]

2022-04-12 Thread David Malcolm via Gcc-patches
On Sat, 2022-04-09 at 14:05 -0400, Antoni Boucher wrote: > Here's the updated patch. Thanks. I updated the patch somewhat: * fixed up some hunks that didn't quite apply * whitespace fixes * added a missing comment * regenerated .texinfo from .rst * test-bitcast.c failed for me; the bitcast of -5.

Re: [PATCH] libgccjit: Add support for bitcasts [PR104071]

2022-04-09 Thread Antoni Boucher via Gcc-patches
Here's the updated patch. On Fri, 2022-04-08 at 15:22 -0400, David Malcolm wrote: > On Fri, 2022-01-21 at 18:41 -0500, Antoni Boucher wrote: > > Hi. > > Here's the updated patch. > > > > Thanks.  Review below: > > [...snip...] > > > diff --git a/gcc/jit/libgccjit.cc b/gcc/jit/libgccjit.cc > >

Re: [PATCH] libgccjit: Add support for bitcasts [PR104071]

2022-04-08 Thread David Malcolm via Gcc-patches
On Fri, 2022-01-21 at 18:41 -0500, Antoni Boucher wrote: > Hi. > Here's the updated patch. > Thanks. Review below: [...snip...] > diff --git a/gcc/jit/libgccjit.cc b/gcc/jit/libgccjit.cc > index 4c352e8c93d..6bf1e1ceee0 100644 > --- a/gcc/jit/libgccjit.cc > +++ b/gcc/jit/libgccjit.cc > @@ -240

Re: [PATCH] libgccjit: Add support for bitcasts [PR104071]

2022-01-21 Thread Antoni Boucher via Gcc-patches
Hi. Here's the updated patch. See comments below. Le mardi 18 janvier 2022 à 18:06 -0500, David Malcolm a écrit : > On Mon, 2022-01-17 at 19:30 -0500, Antoni Boucher via Gcc-patches > wrote: > > I was missing the define, so I added it. > > Here's the new patch with it. > > Thanks for the patch.

Re: [PATCH] libgccjit: Add support for bitcasts [PR104071]

2022-01-18 Thread David Malcolm via Gcc-patches
On Mon, 2022-01-17 at 19:30 -0500, Antoni Boucher via Gcc-patches wrote: > I was missing the define, so I added it. > Here's the new patch with it. Thanks for the patch. > Le lundi 17 janvier 2022 à 17:18 -0500, Antoni Boucher via Jit a > écrit : > > Hi. > > This patch add support for bitcasts in

Re: [PATCH] libgccjit: Add support for bitcasts [PR104071]

2022-01-17 Thread Antoni Boucher via Gcc-patches
I was missing the define, so I added it. Here's the new patch with it. Le lundi 17 janvier 2022 à 17:18 -0500, Antoni Boucher via Jit a écrit : > Hi. > This patch add support for bitcasts in libgccjit. > > It passes the JIT tests, but since I added a function in tree.c, I > wonder if I should run