Re: [PATCH] libcpp: Use [[likely]] conditionally

2021-11-23 Thread Jeff Law via Gcc-patches
On 11/23/2021 1:34 PM, Christophe Lyon wrote: On Tue, Nov 23, 2021 at 4:41 PM Jeff Law via Gcc-patches wrote: On 11/23/2021 8:26 AM, Christophe LYON via Gcc-patches wrote: > Hi! > > On 23/11/2021 01:26, Jeff Law via Gcc-patches wrote: >> >> >> On 11/22/2021

Re: [PATCH] libcpp: Use [[likely]] conditionally

2021-11-23 Thread Jakub Jelinek via Gcc-patches
On Tue, Nov 23, 2021 at 09:34:04PM +0100, Christophe Lyon via Gcc-patches wrote: > > > This patch breaks the build when the host compiler is gcc-4.8.5, > > > because __has_cpp_attribute is not defined. > > Sigh. I'd like to move to a more recent prereq if we could. > > > > I don't know why we hav

Re: [PATCH] libcpp: Use [[likely]] conditionally

2021-11-23 Thread Christophe Lyon via Gcc-patches
On Tue, Nov 23, 2021 at 4:41 PM Jeff Law via Gcc-patches < gcc-patches@gcc.gnu.org> wrote: > > > On 11/23/2021 8:26 AM, Christophe LYON via Gcc-patches wrote: > > Hi! > > > > On 23/11/2021 01:26, Jeff Law via Gcc-patches wrote: > >> > >> > >> On 11/22/2021 10:22 AM, Marek Polacek via Gcc-patches w

Re: [PATCH] libcpp: Use [[likely]] conditionally

2021-11-23 Thread Jeff Law via Gcc-patches
On 11/23/2021 8:26 AM, Christophe LYON via Gcc-patches wrote: Hi! On 23/11/2021 01:26, Jeff Law via Gcc-patches wrote: On 11/22/2021 10:22 AM, Marek Polacek via Gcc-patches wrote: Let's hide [[likely]] behind a macro, to suppress warnings if the compiler doesn't support it. Co-authored-b

Re: [PATCH] libcpp: Use [[likely]] conditionally

2021-11-23 Thread Marek Polacek via Gcc-patches
On Tue, Nov 23, 2021 at 04:26:19PM +0100, Christophe LYON via Gcc-patches wrote: > Hi! > > On 23/11/2021 01:26, Jeff Law via Gcc-patches wrote: > > > > > > On 11/22/2021 10:22 AM, Marek Polacek via Gcc-patches wrote: > > > Let's hide [[likely]] behind a macro, to suppress warnings if the > > > c

Re: [PATCH] libcpp: Use [[likely]] conditionally

2021-11-23 Thread Christophe LYON via Gcc-patches
Hi! On 23/11/2021 01:26, Jeff Law via Gcc-patches wrote: On 11/22/2021 10:22 AM, Marek Polacek via Gcc-patches wrote: Let's hide [[likely]] behind a macro, to suppress warnings if the compiler doesn't support it. Co-authored-by: Jonathan Wakely Bootstrapped/regtested on x86_64-pc-linux-gnu

Re: [PATCH] libcpp: Use [[likely]] conditionally

2021-11-22 Thread Jeff Law via Gcc-patches
On 11/22/2021 10:22 AM, Marek Polacek via Gcc-patches wrote: Let's hide [[likely]] behind a macro, to suppress warnings if the compiler doesn't support it. Co-authored-by: Jonathan Wakely Bootstrapped/regtested on x86_64-pc-linux-gnu, ok for trunk? PR preprocessor/103355 libcpp/Ch