Re: [PATCH] libcpp: Improve encapsulation of label_text

2022-07-15 Thread Jonathan Wakely via Gcc-patches
On Thu, 14 Jul 2022 at 22:31, David Malcolm wrote: > > On Thu, 2022-07-14 at 22:10 +0100, Jonathan Wakely wrote: > > Thanks for the patch. > > > I'm not sure if label_text::get () is the best name for the new > > accessor. Other options include buffer () and c_str () but I don't > > see a > > compe

Re: [PATCH] libcpp: Improve encapsulation of label_text

2022-07-14 Thread David Malcolm via Gcc-patches
On Thu, 2022-07-14 at 22:10 +0100, Jonathan Wakely wrote: Thanks for the patch. > I'm not sure if label_text::get () is the best name for the new > accessor. Other options include buffer () and c_str () but I don't > see a > compelling reason to prefer either of those. label_text::get should ret