Re: [PATCH] libcpp: Implement clang -Wheader-guard warning [PR96842]

2024-10-01 Thread Sam James
Marek Polacek writes: > On Wed, Sep 11, 2024 at 11:26:42PM +0200, Jakub Jelinek wrote: > [...] >> --- gcc/testsuite/c-c++-common/cpp/Wheader-guard-1-1.h.jj2024-09-11 >> 19:26:39.912834079 +0200 >> +++ gcc/testsuite/c-c++-common/cpp/Wheader-guard-1-1.h 2024-09-11 >> 19:02:02.414054285

Re: [PATCH] libcpp: Implement clang -Wheader-guard warning [PR96842]

2024-10-01 Thread Marek Polacek
On Wed, Sep 11, 2024 at 11:26:42PM +0200, Jakub Jelinek wrote: > Hi! > > The following patch implements the clang -Wheader-guard warning, which warns > if a valid multiple inclusion header guard's #ifndef/#if !defined directive > is immediately (no other non-line directives nor other (non-comment)

Re: [PATCH] libcpp: Implement clang -Wheader-guard warning [PR96842]

2024-09-12 Thread David Malcolm
On Thu, 2024-09-12 at 17:18 +0200, Jakub Jelinek wrote: > On Thu, Sep 12, 2024 at 11:12:26AM -0400, David Malcolm wrote: > > We were chatting on IRC about how it would be nice to be able to > > use > > %qs in libcppp diagnostics; here is an example (rather than using > > \"%s\"). > > Yeah, I'm wor

Re: [PATCH] libcpp: Implement clang -Wheader-guard warning [PR96842]

2024-09-12 Thread Jakub Jelinek
On Thu, Sep 12, 2024 at 11:12:26AM -0400, David Malcolm wrote: > We were chatting on IRC about how it would be nice to be able to use > %qs in libcppp diagnostics; here is an example (rather than using > \"%s\"). Yeah, I'm working on a patch for that. > Not a blocker, but it occurs to me that ide

Re: [PATCH] libcpp: Implement clang -Wheader-guard warning [PR96842]

2024-09-12 Thread David Malcolm
On Wed, 2024-09-11 at 23:26 +0200, Jakub Jelinek wrote: > Hi! > > The following patch implements the clang -Wheader-guard warning, > which warns > if a valid multiple inclusion header guard's #ifndef/#if !defined > directive > is immediately (no other non-line directives nor other (non-comment) >

Re: [PATCH] libcpp: Implement clang -Wheader-guard warning [PR96842]

2024-09-12 Thread Eric Gallager
On Wed, Sep 11, 2024 at 5:28 PM Jakub Jelinek wrote: > > Hi! > > The following patch implements the clang -Wheader-guard warning, which warns > if a valid multiple inclusion header guard's #ifndef/#if !defined directive > is immediately (no other non-line directives nor other (non-comment) > token