Re: [PATCH] libcpp: Implement -Wbidi-chars for CVE-2021-42574 [PR103026]

2022-01-14 Thread Stephan Bergmann via Gcc-patches
On 14/01/2022 14:28, Marek Polacek wrote: On Fri, Jan 14, 2022 at 10:23:16AM +0100, Stephan Bergmann wrote: On 30/11/2021 16:27, Marek Polacek wrote: I guess we were concerned with programs that generate other programs. Maybe UCNs should be ignored by default. There's still time to adjust the

Re: [PATCH] libcpp: Implement -Wbidi-chars for CVE-2021-42574 [PR103026]

2022-01-14 Thread Marek Polacek via Gcc-patches
On Fri, Jan 14, 2022 at 10:23:16AM +0100, Stephan Bergmann wrote: > On 30/11/2021 16:27, Marek Polacek wrote: > > I guess we were concerned with programs that generate other programs. > > Maybe UCNs should be ignored by default. There's still time to adjust > > the behavior. > > Is there any upda

Re: [PATCH] libcpp: Implement -Wbidi-chars for CVE-2021-42574 [PR103026]

2022-01-14 Thread Stephan Bergmann via Gcc-patches
On 30/11/2021 16:27, Marek Polacek wrote: I guess we were concerned with programs that generate other programs. Maybe UCNs should be ignored by default. There's still time to adjust the behavior. Is there any update on this? Shall I file a bug? As-is, -Wbidi-chars is unusable for building L

Re: [PATCH] libcpp: Implement -Wbidi-chars for CVE-2021-42574 [PR103026]

2021-11-30 Thread Marek Polacek via Gcc-patches
On Tue, Nov 30, 2021 at 04:00:01PM +0100, Stephan Bergmann wrote: > On 30/11/2021 14:26, Marek Polacek wrote: > > On Tue, Nov 30, 2021 at 09:38:57AM +0100, Stephan Bergmann wrote: > > > On 15/11/2021 18:28, Marek Polacek via Gcc-patches wrote: > > > > On Mon, Nov 08, 2021 at 04:33:43PM -0500, Marek

Re: [PATCH] libcpp: Implement -Wbidi-chars for CVE-2021-42574 [PR103026]

2021-11-30 Thread Stephan Bergmann via Gcc-patches
On 30/11/2021 14:26, Marek Polacek wrote: On Tue, Nov 30, 2021 at 09:38:57AM +0100, Stephan Bergmann wrote: On 15/11/2021 18:28, Marek Polacek via Gcc-patches wrote: On Mon, Nov 08, 2021 at 04:33:43PM -0500, Marek Polacek wrote: Ping, can we conclude on the name? IMHO, -Wbidirectional is jus

Re: [PATCH] libcpp: Implement -Wbidi-chars for CVE-2021-42574 [PR103026]

2021-11-30 Thread Marek Polacek via Gcc-patches
On Tue, Nov 30, 2021 at 09:38:57AM +0100, Stephan Bergmann wrote: > On 15/11/2021 18:28, Marek Polacek via Gcc-patches wrote: > > On Mon, Nov 08, 2021 at 04:33:43PM -0500, Marek Polacek wrote: > > > Ping, can we conclude on the name? IMHO, -Wbidirectional is just fine, > > > but changing the name

Re: [PATCH] libcpp: Implement -Wbidi-chars for CVE-2021-42574 [PR103026]

2021-11-30 Thread Stephan Bergmann via Gcc-patches
On 15/11/2021 18:28, Marek Polacek via Gcc-patches wrote: On Mon, Nov 08, 2021 at 04:33:43PM -0500, Marek Polacek wrote: Ping, can we conclude on the name? IMHO, -Wbidirectional is just fine, but changing the name is a trivial operation. Here's a patch with a better name (suggested by Jonath

Re: [PATCH] libcpp: Implement -Wbidi-chars for CVE-2021-42574 [PR103026]

2021-11-15 Thread David Malcolm via Gcc-patches
> On Mon, Nov 08, 2021 at 04:33:43PM -0500, Marek Polacek wrote: > > Ping, can we conclude on the name? IMHO, -Wbidirectional is just fine, > > but changing the name is a trivial operation. > > Here's a patch with a better name (suggested by Jonathan W.). Otherwise no > changes. Thanks for im