Re: [PATCH] i386: Skip ENDBR32 at nested function entry

2020-02-13 Thread Uros Bizjak
On Wed, Feb 12, 2020 at 1:21 PM H.J. Lu wrote: > > On Mon, Feb 10, 2020 at 12:01 PM Uros Bizjak wrote: > > > > On Mon, Feb 10, 2020 at 8:53 PM H.J. Lu wrote: > > > > > > On Mon, Feb 10, 2020 at 11:40 AM Uros Bizjak wrote: > > > > > > > > On Mon, Feb 10, 2020 at 8:22 PM H.J. Lu wrote: > > > > >

Re: [PATCH] i386: Skip ENDBR32 at nested function entry

2020-02-12 Thread H.J. Lu
On Mon, Feb 10, 2020 at 12:01 PM Uros Bizjak wrote: > > On Mon, Feb 10, 2020 at 8:53 PM H.J. Lu wrote: > > > > On Mon, Feb 10, 2020 at 11:40 AM Uros Bizjak wrote: > > > > > > On Mon, Feb 10, 2020 at 8:22 PM H.J. Lu wrote: > > > > > > > > Since nested function isn't only called directly, there i

Re: [PATCH] i386: Skip ENDBR32 at nested function entry

2020-02-10 Thread Uros Bizjak
On Mon, Feb 10, 2020 at 8:53 PM H.J. Lu wrote: > > On Mon, Feb 10, 2020 at 11:40 AM Uros Bizjak wrote: > > > > On Mon, Feb 10, 2020 at 8:22 PM H.J. Lu wrote: > > > > > > Since nested function isn't only called directly, there is ENDBR32 at > > > function entry and we need to skip it for direct j

Re: [PATCH] i386: Skip ENDBR32 at nested function entry

2020-02-10 Thread H.J. Lu
On Mon, Feb 10, 2020 at 11:40 AM Uros Bizjak wrote: > > On Mon, Feb 10, 2020 at 8:22 PM H.J. Lu wrote: > > > > Since nested function isn't only called directly, there is ENDBR32 at > > function entry and we need to skip it for direct jump in trampoline. > > Hm, I'm afraid I don't understand this

Re: [PATCH] i386: Skip ENDBR32 at nested function entry

2020-02-10 Thread Uros Bizjak
On Mon, Feb 10, 2020 at 8:22 PM H.J. Lu wrote: > > Since nested function isn't only called directly, there is ENDBR32 at > function entry and we need to skip it for direct jump in trampoline. Hm, I'm afraid I don't understand this comment. Can you perhaps rephrase it? Uros. > Tested on Linux/x8