Re: [PATCH] i386: Fix emissing of __builtin_cpu_supports.

2021-12-14 Thread Jakub Jelinek via Gcc-patches
On Tue, Dec 14, 2021 at 04:07:55PM +0100, Martin Liška wrote: > On 12/14/21 11:28, Jakub Jelinek wrote: > > Wouldn't this be better done only if field_val has the msb set > > Yes, updated in the attached patch. > > > and keep the CONVERT_EXPR otherwise (why isn't it NOP_EXPR?)? > > Dunno, but I

Re: [PATCH] i386: Fix emissing of __builtin_cpu_supports.

2021-12-14 Thread Martin Liška
On 12/14/21 11:28, Jakub Jelinek wrote: Wouldn't this be better done only if field_val has the msb set Yes, updated in the attached patch. and keep the CONVERT_EXPR otherwise (why isn't it NOP_EXPR?)? Dunno, but I can prepare a separate patch (likely stage1 material, right)? Note that are o

Re: [PATCH] i386: Fix emissing of __builtin_cpu_supports.

2021-12-14 Thread Jakub Jelinek via Gcc-patches
On Tue, Dec 14, 2021 at 10:55:01AM +0100, Martin Liška wrote: > The patch fixes __builtin_cpu_supports("avx512vbmi2") which returns a negative > value (that's not allowed in the documentation). > > I also checked ppc target that does the same, and __builtin_cpu_is, which > are fine. > > Patch can