Re: [PATCH] handle conditionals in -Wstringop-overflow et al. (PR 92936)

2020-12-01 Thread Jeff Law via Gcc-patches
On 11/30/20 5:58 PM, Martin Sebor wrote: > > What I meant was that the recursion in compute_objsize has been > there in various forms since at least GCC 8 (it's still in other > parts of GCC today), and it hasn't been a source of reported > problems. Understood.  Could be due to a variety of fac

Re: [PATCH] handle conditionals in -Wstringop-overflow et al. (PR 92936)

2020-11-30 Thread Martin Sebor via Gcc-patches
On 11/30/20 1:49 PM, Jeff Law wrote: On 11/29/20 3:27 PM, Martin Sebor wrote: On 11/13/20 2:34 PM, Jeff Law wrote: On 11/2/20 7:24 PM, Martin Sebor wrote: The attached patch extends compute_objsize() to handle conditional expressions represented either as PHIs or MIN_EXPR and MAX_EXPR. To

Re: [PATCH] handle conditionals in -Wstringop-overflow et al. (PR 92936)

2020-11-30 Thread Jeff Law via Gcc-patches
On 11/29/20 3:27 PM, Martin Sebor wrote: > On 11/13/20 2:34 PM, Jeff Law wrote: >> >> On 11/2/20 7:24 PM, Martin Sebor wrote: >>> The attached patch extends compute_objsize() to handle conditional >>> expressions represented either as PHIs or MIN_EXPR and MAX_EXPR. >>> >>> To simplify the handli

Re: [PATCH] handle conditionals in -Wstringop-overflow et al. (PR 92936)

2020-11-29 Thread Martin Sebor via Gcc-patches
On 11/13/20 2:34 PM, Jeff Law wrote: On 11/2/20 7:24 PM, Martin Sebor wrote: The attached patch extends compute_objsize() to handle conditional expressions represented either as PHIs or MIN_EXPR and MAX_EXPR. To simplify the handling of the -Wstringop-overflow/-overread warnings the change fac

Re: [PATCH] handle conditionals in -Wstringop-overflow et al. (PR 92936)

2020-11-13 Thread Jeff Law via Gcc-patches
On 11/2/20 7:24 PM, Martin Sebor wrote: > The attached patch extends compute_objsize() to handle conditional > expressions represented either as PHIs or MIN_EXPR and MAX_EXPR. > > To simplify the handling of the -Wstringop-overflow/-overread > warnings the change factors this code out of tree-ssa