Re: [PATCH] ggc-page loop

2017-05-03 Thread Nathan Sidwell
On 05/03/2017 05:54 AM, Richard Biener wrote: He does, albeit in a coding way I dislike (watch how the iterator update is done in the condition!) Sorry you dislike that. I've used that kind of loop idiom, since for ever though. nathan -- Nathan Sidwell

Re: [PATCH] ggc-page loop

2017-05-03 Thread Richard Biener
On Wed, May 3, 2017 at 2:09 AM, Andrew Pinski wrote: > On Tue, May 2, 2017 at 3:41 PM, Nathan Sidwell wrote: >> This loop in ggc-page confused me, because the iterator is one greater than >> the indexing value. Also the formatting of the array indexing is incorrect. >> >> Fixed thusly, and appli

Re: [PATCH] ggc-page loop

2017-05-02 Thread Andrew Pinski
On Tue, May 2, 2017 at 3:41 PM, Nathan Sidwell wrote: > This loop in ggc-page confused me, because the iterator is one greater than > the indexing value. Also the formatting of the array indexing is incorrect. > > Fixed thusly, and applied as obvious after booting on x86_64-linux-gnu - for (i =