Re: [PATCH] genmatch: isolate reporting into a function

2018-09-14 Thread Jeff Law
On 9/3/18 1:56 AM, Martin Liška wrote: > Hi. > > This is small improvement for {gimple,generic}-match.c files. > The code path that reports application of a pattern is now guarded > with __builtin_expect. And reporting function lives in gimple.c. > > For gimple-match.o, difference is: > > bloaty

Re: [PATCH] genmatch: isolate reporting into a function

2018-09-04 Thread Richard Biener
On Mon, Sep 3, 2018 at 4:19 PM Martin Liška wrote: > > On 09/03/2018 03:31 PM, Richard Biener wrote: > > On Mon, Sep 3, 2018 at 2:09 PM Martin Liška wrote: > >> > >> On 09/03/2018 10:19 AM, Richard Biener wrote: > >>> On Mon, Sep 3, 2018 at 9:56 AM Martin Liška wrote: > > Hi. > >

Re: [PATCH] genmatch: isolate reporting into a function

2018-09-03 Thread Martin Liška
On 09/03/2018 03:31 PM, Richard Biener wrote: > On Mon, Sep 3, 2018 at 2:09 PM Martin Liška wrote: >> >> On 09/03/2018 10:19 AM, Richard Biener wrote: >>> On Mon, Sep 3, 2018 at 9:56 AM Martin Liška wrote: Hi. This is small improvement for {gimple,generic}-match.c files.

Re: [PATCH] genmatch: isolate reporting into a function

2018-09-03 Thread Richard Biener
On Mon, Sep 3, 2018 at 2:09 PM Martin Liška wrote: > > On 09/03/2018 10:19 AM, Richard Biener wrote: > > On Mon, Sep 3, 2018 at 9:56 AM Martin Liška wrote: > >> > >> Hi. > >> > >> This is small improvement for {gimple,generic}-match.c files. > >> The code path that reports application of a patter

Re: [PATCH] genmatch: isolate reporting into a function

2018-09-03 Thread Martin Liška
On 09/03/2018 10:19 AM, Richard Biener wrote: > On Mon, Sep 3, 2018 at 9:56 AM Martin Liška wrote: >> >> Hi. >> >> This is small improvement for {gimple,generic}-match.c files. >> The code path that reports application of a pattern is now guarded >> with __builtin_expect. And reporting function li

Re: [PATCH] genmatch: isolate reporting into a function

2018-09-03 Thread Richard Biener
On Mon, Sep 3, 2018 at 9:56 AM Martin Liška wrote: > > Hi. > > This is small improvement for {gimple,generic}-match.c files. > The code path that reports application of a pattern is now guarded > with __builtin_expect. And reporting function lives in gimple.c. > > For gimple-match.o, difference is