On 5/28/20 1:20 PM, Jakub Jelinek wrote:
On Thu, May 28, 2020 at 11:09:41AM +0200, Martin Liška wrote:
On 5/28/20 11:05 AM, Pierre-Marie de Rodat wrote:
Thanks! The updated patch is attached.
The patch is fine, please install it.
I'd like to mention that for file renames, perhaps it is acce
On Thu, May 28, 2020 at 11:09:41AM +0200, Martin Liška wrote:
> On 5/28/20 11:05 AM, Pierre-Marie de Rodat wrote:
> > Thanks! The updated patch is attached.
>
> The patch is fine, please install it.
I'd like to mention that for file renames, perhaps it is acceptable not to
have a ChangeLog entry
On 28/05/2020 11:09, Martin Liška wrote:
On 5/28/20 11:05 AM, Pierre-Marie de Rodat wrote:
Thanks! The updated patch is attached.
The patch is fine, please install it.
Now pushed. Thank you again.
--
Pierre-Marie de Rodat
On 5/28/20 11:05 AM, Pierre-Marie de Rodat wrote:
Thanks! The updated patch is attached.
The patch is fine, please install it.
Thanks,
Martin
On 27/05/2020 19:50, Martin Liška wrote:
Thank you very much for working on this! It's a good idea that's currently
not supported.
You are welcome, I’m glad to contribute. :-)
However, this is available for unidiff package starting from version
0.6.0. With a bit older
release I see:
On 5/27/20 7:50 PM, Martin Liška wrote:
We'll need here a skip based on version of unidiff. So something like:
@pytest.mark.skipif
?
I believe something like:
diff --git a/contrib/gcc-changelog/git_email.py
b/contrib/gcc-changelog/git_email.py
index 6e42629cf07..afa6771c7fe 100755
--- a/contr
On 5/27/20 4:29 PM, Pierre-Marie de Rodat wrote:
So far, we expect from a commit that renames a file to contain a
changelog entry only for the new name. For example, after the following
commit:
$ git move foo bar
$ git commit
We expect the following changelog:
* bar: Renamed from f
