Re: [PATCH] fortran: ICE using undeclared symbol in array constructor, PR93484

2020-02-24 Thread Tobias Burnus
On 2/24/20 3:50 PM, Mark Eggleston wrote: I've had a quick look and there doesn't appear to be a test for using a non-constant for kind arguments. I think a proper set of tests for invalid kind arguments that covers declarations and intrinsic arguments should be added that is separate from this

Re: [PATCH] fortran: ICE using undeclared symbol in array constructor, PR93484

2020-02-24 Thread Mark Eggleston
On 24/02/2020 14:34, Thomas Koenig wrote: Hi Mark, Might need gfc_reduce_init_expr (e); here.  The kind type parameter should be a constant expression. Not needed. I've also checked use of the kind argument, it is evidently checked elsewhere: if k is allowed to be implicitly de

Re: [PATCH] fortran: ICE using undeclared symbol in array constructor, PR93484

2020-02-24 Thread Thomas Koenig
Hi Mark, Might need gfc_reduce_init_expr (e); here.  The kind type parameter should be a constant expression. Not needed. I've also checked use of the kind argument, it is evidently checked elsewhere: if k is allowed to be implicitly declared and is used as the kind argument error

Re: [PATCH] fortran: ICE using undeclared symbol in array constructor, PR93484

2020-02-24 Thread Mark Eggleston
**ping** The following was a reply to https://gcc.gnu.org/ml/fortran/2020-02/msg00042.html see response below. OK to commit? On 11/02/2020 15:23, Steve Kargl wrote: On Tue, Feb 11, 2020 at 12:10:41PM +, Mark Eggleston wrote: Please find attached a patch for PR93484.  The original author

Re: [PATCH] fortran: ICE using undeclared symbol in array constructor, PR93484

2020-02-11 Thread Steve Kargl
On Tue, Feb 11, 2020 at 12:10:41PM +, Mark Eggleston wrote: > Please find attached a patch for PR93484.  The original author is Steve > Kargl. I have added the test cases. > > OK for master? I obviously think the patch is ok, but I'll let someone else review it. >     Steven G. Kargl  > >