Re: [PATCH] don't declare header-defined functions both static and inline, pt 2

2023-02-27 Thread Patrick Palka via Gcc-patches
On Thu, 16 Feb 2023, Patrick Palka wrote: > This fixes some header-defined functions that are undesirably declared > static and weren't caught by the "^static inline" pattern used in the > previous patch. > > gcc/ChangeLog: > > * hash-table.h (gt_pch_nx): Remove static. > * lra-int.h

Re: [PATCH] don't declare header-defined functions both static and inline

2023-02-16 Thread Jakub Jelinek via Gcc-patches
On Thu, Feb 16, 2023 at 08:37:34AM -0500, Patrick Palka wrote: > I can confirm that this patch only modifies headers that reside in > $prefix/lib/gcc/x86_64-pc-linux-gnu/13.0.1/plugin/include/ > (with --enable-languages=c,c++,fortran,objc,obj-c++ --enable-jit make install) > > Good point, I was ab

Re: [PATCH] don't declare header-defined functions both static and inline

2023-01-31 Thread Eric Botcazou via Gcc-patches
> 3) we have also gcc/ada/gcc-interface/*.h with > ada.h:#define INLINE static inline > gigi.h:static inline unsigned HOST_WIDE_INT > gigi.h:static inline bool > gigi.h:static inline bool > gigi.h:static inline bool > gigi.h:static inline tree > gigi.h:static inline tree > gigi.h:static inline tree

Re: [PATCH] don't declare header-defined functions both static and inline

2023-01-31 Thread Richard Biener via Gcc-patches
On Tue, Jan 31, 2023 at 9:43 AM Jakub Jelinek wrote: > > On Tue, Jan 31, 2023 at 08:05:15AM +0100, Richard Biener via Gcc-patches > wrote: > > On Tue, Jan 31, 2023 at 4:39 AM Patrick Palka via Gcc-patches > > wrote: > > > > > > Many functions defined in our headers are declared 'static inline' w

Re: [PATCH] don't declare header-defined functions both static and inline

2023-01-31 Thread Jakub Jelinek via Gcc-patches
On Tue, Jan 31, 2023 at 08:05:15AM +0100, Richard Biener via Gcc-patches wrote: > On Tue, Jan 31, 2023 at 4:39 AM Patrick Palka via Gcc-patches > wrote: > > > > Many functions defined in our headers are declared 'static inline' which > > is a vestige from when GCC's implementation language was C.