Re: [PATCH] diagnostics: Consistently add fixit hint for implicit builtin declaration

2020-06-05 Thread Joseph Myers
This patch is OK. -- Joseph S. Myers jos...@codesourcery.com

Re: [PATCH] diagnostics: Consistently add fixit hint for implicit builtin declaration

2020-06-04 Thread Mark Wielaard
Hi, On Fri, 2020-05-29 at 09:13 -0600, Martin Sebor wrote: > On 5/28/20 7:13 PM, Mark Wielaard wrote: > > On Thu, May 28, 2020 at 06:21:39PM -0600, Martin Sebor wrote: > > > Although few tests bother with it, since you add an option for > > > the existing warning where there was none before, an ev

Re: [PATCH] diagnostics: Consistently add fixit hint for implicit builtin declaration

2020-05-29 Thread Martin Sebor via Gcc-patches
On 5/28/20 7:13 PM, Mark Wielaard wrote: Hi Martin, On Thu, May 28, 2020 at 06:21:39PM -0600, Martin Sebor wrote: Although few tests bother with it, since you add an option for the existing warning where there was none before, an even more exhaustive test than the one you added would also verif

Re: [PATCH] diagnostics: Consistently add fixit hint for implicit builtin declaration

2020-05-28 Thread Mark Wielaard
Hi Martin, On Thu, May 28, 2020 at 06:21:39PM -0600, Martin Sebor wrote: > Although few tests bother with it, since you add an option for > the existing warning where there was none before, an even more > exhaustive test than the one you added would also verify the same > option can be used to sup

Re: [PATCH] diagnostics: Consistently add fixit hint for implicit builtin declaration

2020-05-28 Thread Martin Sebor via Gcc-patches
On 5/28/20 5:16 PM, Mark Wielaard wrote: There are two warnings that might trigger when a builtin function is used but not declared yet. Both called through implicitly_declare in c-decl. The first in implicit_decl_warning does warn for builtins, but does not add a fixit hint for them (only for no