Re: [PATCH] cplus-demangler, free resource after a failed call to gnu_special.

2014-05-28 Thread Pedro Alves
On 05/22/2014 12:57 PM, Thomas Schwinge wrote: > On Wed, 14 May 2014 15:20:16 +0100, Gary Benson wrote: >> Andrew Burgess wrote: >>> On 14/05/2014 10:01 AM, Gary Benson wrote: Ian Lance Taylor wrote: > This patch is OK. Andrew, would you like me to commit this? >>> >>> Yes pleas

Re: [PATCH] cplus-demangler, free resource after a failed call to gnu_special.

2014-05-22 Thread Gary Benson
Thomas Schwinge wrote: > On Thu, 22 May 2014 17:02:08 +0100, Gary Benson wrote: > > Thomas Schwinge wrote: > > > In GCC, I'm consistenly seeing the following new failure: > > > > > > ./test-demangle < > > > ../../../source/libiberty/testsuite/demangle-expected > > > FAIL at line 4350, op

Re: [PATCH] cplus-demangler, free resource after a failed call to gnu_special.

2014-05-22 Thread Thomas Schwinge
Hi Gary! On Thu, 22 May 2014 17:02:08 +0100, Gary Benson wrote: > Thomas Schwinge wrote: > > In GCC, I'm consistenly seeing the following new failure: > > > > ./test-demangle < ../../../source/libiberty/testsuite/demangle-expected > > FAIL at line 4350, options --format=auto --no-params:

Re: [PATCH] cplus-demangler, free resource after a failed call to gnu_special.

2014-05-22 Thread Gary Benson
Hi Thomas, Thomas Schwinge wrote: > In GCC, I'm consistenly seeing the following new failure: > > ./test-demangle < ../../../source/libiberty/testsuite/demangle-expected > FAIL at line 4350, options --format=auto --no-params: > in: _QueueNotification_QueueController__$4PPPM_A_INo

Re: [PATCH] cplus-demangler, free resource after a failed call to gnu_special.

2014-05-22 Thread Thomas Schwinge
Hi! On Wed, 14 May 2014 15:20:16 +0100, Gary Benson wrote: > Andrew Burgess wrote: > > On 14/05/2014 10:01 AM, Gary Benson wrote: > > > Ian Lance Taylor wrote: > > > > Andrew Burgess wrote: > > > > > On 09/05/2014 9:53 PM, Ian Lance Taylor wrote: > > > > > > Andrew Burgess wrote: > > > > > > >

Re: [PATCH] cplus-demangler, free resource after a failed call to gnu_special.

2014-05-14 Thread Gary Benson
Andrew Burgess wrote: > On 14/05/2014 10:01 AM, Gary Benson wrote: > > Ian Lance Taylor wrote: > > > Andrew Burgess wrote: > > > > On 09/05/2014 9:53 PM, Ian Lance Taylor wrote: > > > > > Andrew Burgess wrote: > > > > > >if ((AUTO_DEMANGLING || GNU_DEMANGLING)) > > > > > > { > > >

Re: [PATCH] cplus-demangler, free resource after a failed call to gnu_special.

2014-05-14 Thread Andrew Burgess
On 14/05/2014 10:01 AM, Gary Benson wrote: > Ian Lance Taylor wrote: >> Andrew Burgess wrote: >>> On 09/05/2014 9:53 PM, Ian Lance Taylor wrote: Andrew Burgess wrote: >if ((AUTO_DEMANGLING || GNU_DEMANGLING)) > { > success = gnu_special (work, &mangled,

Re: [PATCH] cplus-demangler, free resource after a failed call to gnu_special.

2014-05-14 Thread Gary Benson
Ian Lance Taylor wrote: > Andrew Burgess wrote: > > On 09/05/2014 9:53 PM, Ian Lance Taylor wrote: > > > Andrew Burgess wrote: > > > >if ((AUTO_DEMANGLING || GNU_DEMANGLING)) > > > > { > > > > success = gnu_special (work, &mangled, &decl); > > > > + if (!success

Re: [PATCH] cplus-demangler, free resource after a failed call to gnu_special.

2014-05-11 Thread Ian Lance Taylor
On Sat, May 10, 2014 at 12:13 PM, Andrew Burgess wrote: > On 09/05/2014 9:53 PM, Ian Lance Taylor wrote: >> On Fri, May 9, 2014 at 7:35 AM, Andrew Burgess wrote: >> >>>if ((AUTO_DEMANGLING || GNU_DEMANGLING)) >>> { >>> success = gnu_special (work, &mangled, &decl); >>> +

Re: [PATCH] cplus-demangler, free resource after a failed call to gnu_special.

2014-05-10 Thread Andrew Burgess
On 09/05/2014 9:53 PM, Ian Lance Taylor wrote: > On Fri, May 9, 2014 at 7:35 AM, Andrew Burgess wrote: > >>if ((AUTO_DEMANGLING || GNU_DEMANGLING)) >> { >> success = gnu_special (work, &mangled, &decl); >> + if (!success) >> +{ >> + dele

Re: [PATCH] cplus-demangler, free resource after a failed call to gnu_special.

2014-05-09 Thread Ian Lance Taylor
On Fri, May 9, 2014 at 7:35 AM, Andrew Burgess wrote: >if ((AUTO_DEMANGLING || GNU_DEMANGLING)) > { > success = gnu_special (work, &mangled, &decl); > + if (!success) > +{ > + delete_work_stuff (work); > + string_delete (&de