Re: [PATCH] config/debuginfod.m4: Use PKG_CHECK_MODULES

2020-07-25 Thread H.J. Lu via Gcc-patches
On Fri, Jul 24, 2020 at 1:04 PM Aaron Merey via Gcc-patches wrote: > > On Tue, Jul 21, 2020 at 2:11 PM Aaron Merey wrote: > > > > On Tue, Jul 21, 2020 at 11:20 AM Tom Tromey wrote: > > > > > > Simon> Since it's debuginfo.m4 that is using PKG_CHECK_MODULES, can you > > > put the include > > > Si

Re: [PATCH] config/debuginfod.m4: Use PKG_CHECK_MODULES

2020-07-24 Thread Aaron Merey via Gcc-patches
On Tue, Jul 21, 2020 at 2:11 PM Aaron Merey wrote: > > On Tue, Jul 21, 2020 at 11:20 AM Tom Tromey wrote: > > > > Simon> Since it's debuginfo.m4 that is using PKG_CHECK_MODULES, can you put > > the include > > Simon> of pkg.m4 in debuginfo.m4, instead of in {binutils,gdb}/configure.ac? > > > > S

Re: [PATCH] config/debuginfod.m4: Use PKG_CHECK_MODULES

2020-07-21 Thread Aaron Merey via Gcc-patches
On Tue, Jul 21, 2020 at 11:20 AM Tom Tromey wrote: > > Simon> Since it's debuginfo.m4 that is using PKG_CHECK_MODULES, can you put > the include > Simon> of pkg.m4 in debuginfo.m4, instead of in {binutils,gdb}/configure.ac? > > Simon> Otherwise, from GDB's point of view I think it looks good, unl

Re: [PATCH] config/debuginfod.m4: Use PKG_CHECK_MODULES

2020-07-21 Thread Tom Tromey
Simon> Since it's debuginfo.m4 that is using PKG_CHECK_MODULES, can you put the include Simon> of pkg.m4 in debuginfo.m4, instead of in {binutils,gdb}/configure.ac? Simon> Otherwise, from GDB's point of view I think it looks good, unless Simon> Tom has some things to add. I'm happy with it. Tha

Re: [PATCH] config/debuginfod.m4: Use PKG_CHECK_MODULES

2020-07-19 Thread Simon Marchi
On 2020-07-16 6:37 p.m., Aaron Merey wrote: > On Fri, May 8, 2020 at 4:56 PM Tom Tromey wrote: >> >>> "Aaron" == Aaron Merey via Binutils writes: >> >> Aaron> * Makefile.in: Replace LIBDEBUGINFOD with DEBUGINFOD_LIBS. >> Aaron> * aclocal.m4: Rebuild. >> >> Instead of inlining

Re: [PATCH] config/debuginfod.m4: Use PKG_CHECK_MODULES

2020-07-16 Thread Aaron Merey via Gcc-patches
On Fri, May 8, 2020 at 4:56 PM Tom Tromey wrote: > > > "Aaron" == Aaron Merey via Binutils writes: > > Aaron> * Makefile.in: Replace LIBDEBUGINFOD with DEBUGINFOD_LIBS. > Aaron> * aclocal.m4: Rebuild. > > Instead of inlining pkg.m4 into aclocal.m4, how about making > config/pk

Re: [PATCH] config/debuginfod.m4: Use PKG_CHECK_MODULES

2020-07-16 Thread Aaron Merey via Gcc-patches
Hi Tom, Sorry for the delay, I've modified the patch to include config/pkg.m4. Aaron Use PKG_CHECK_MODULES to set debuginfod autoconf vars. Also add pkg.m4 to config/. ChangeLog: * config/debuginfod.m4: use PKG_CHECK_MODULES. * config/pkg.m4: New file. * configure: Reb

Re: [PATCH] config/debuginfod.m4: Use PKG_CHECK_MODULES

2020-05-08 Thread Tom Tromey
> "Aaron" == Aaron Merey via Binutils writes: Aaron> * Makefile.in: Replace LIBDEBUGINFOD with DEBUGINFOD_LIBS. Aaron> * aclocal.m4: Rebuild. Instead of inlining pkg.m4 into aclocal.m4, how about making config/pkg.m4 and then using m4_include from gdb/acinclude.m4? That's wha

Re: [PATCH] config/debuginfod.m4: Use PKG_CHECK_MODULES

2020-05-05 Thread Aaron Merey via Gcc-patches
On Tue, May 5, 2020 at 12:41 PM Jeff Law wrote: > > On Fri, 2020-05-01 at 22:29 -0400, Aaron Merey via Gcc-patches wrote: > > Hello, > > > > I'm not sure if this is the right mailing list for this patch but it > > modifies > > the top level directory of binutils-gdb for which I understand GCC to

Re: [PATCH] config/debuginfod.m4: Use PKG_CHECK_MODULES

2020-05-05 Thread Jeff Law via Gcc-patches
On Fri, 2020-05-01 at 22:29 -0400, Aaron Merey via Gcc-patches wrote: > Hello, > > I'm not sure if this is the right mailing list for this patch but it modifies > the top level directory of binutils-gdb for which I understand GCC to be the > upstream. The purpose of this patch is to use PKG_CHEC