Re: [PATCH] color diagnostics markers

2013-04-15 Thread Jakub Jelinek
On Mon, Apr 15, 2013 at 04:14:58AM -0500, Gabriel Dos Reis wrote: > > Defining a variable in my environment counts as a clear intention. > > If you invoke GCC on command line with explicit option requesting > colors, I don't think there is any doubt that. However, I dispute the > intent to be so

Re: [PATCH] color diagnostics markers

2013-04-15 Thread Gabriel Dos Reis
On Sun, Apr 14, 2013 at 4:53 PM, Marc Glisse wrote: > On Wed, 10 Apr 2013, Gabriel Dos Reis wrote: > >> On Wed, Apr 10, 2013 at 1:42 PM, Manuel López-Ibáñez >> wrote: >>> >>> On 9 April 2013 15:21, Jakub Jelinek wrote: white). The default is still -fdiagnostics-color=never, can be cha

Re: [PATCH] color diagnostics markers

2013-04-14 Thread Marc Glisse
On Wed, 10 Apr 2013, Gabriel Dos Reis wrote: On Wed, Apr 10, 2013 at 1:42 PM, Manuel López-Ibáñez wrote: On 9 April 2013 15:21, Jakub Jelinek wrote: white). The default is still -fdiagnostics-color=never, can be changed later on. Apart from my comments elsewhere (http://gcc.gnu.org/ml/gcc

Re: [PATCH] color diagnostics markers

2013-04-11 Thread Manuel López-Ibáñez
On 11 April 2013 03:54, Gabriel Dos Reis wrote: > As I stated before, our pursuit of enabling everything new thing by default > may have made C++ diagnostics more terrifying. Do you have examples of C++ diagnostics that are more terrifying now than in, say, GCC 4.2? Cheers, Manuel.

Re: [PATCH] color diagnostics markers

2013-04-11 Thread Richard Biener
On Thu, Apr 11, 2013 at 3:54 AM, Gabriel Dos Reis wrote: > On Wed, Apr 10, 2013 at 1:42 PM, Manuel López-Ibáñez > wrote: >> On 9 April 2013 15:21, Jakub Jelinek wrote: >>> white). The default is still -fdiagnostics-color=never, can be changed >>> later on. >> >> Apart from my comments elsewhere

Re: [PATCH] color diagnostics markers

2013-04-10 Thread Gabriel Dos Reis
On Wed, Apr 10, 2013 at 1:42 PM, Manuel López-Ibáñez wrote: > On 9 April 2013 15:21, Jakub Jelinek wrote: >> white). The default is still -fdiagnostics-color=never, can be changed >> later on. > > Apart from my comments elsewhere > (http://gcc.gnu.org/ml/gcc-patches/2013-04/msg00614.html), the p

Re: [PATCH] color diagnostics markers

2013-04-10 Thread Manuel López-Ibáñez
On 9 April 2013 15:21, Jakub Jelinek wrote: > white). The default is still -fdiagnostics-color=never, can be changed > later on. Apart from my comments elsewhere (http://gcc.gnu.org/ml/gcc-patches/2013-04/msg00614.html), the patch looks fine to me. But perhaps we should change the default to aut

Re: [PATCH] color diagnostics markers

2013-04-09 Thread Jason Merrill
Looks good to me if nobody else has comments. Jason