Re: [PATCH] c++: ICE with unexpanded pack in asm

2025-06-16 Thread Jason Merrill
On 6/13/25 2:57 PM, Marek Polacek wrote: On Wed, Jun 04, 2025 at 09:18:45PM +0800, yxj-github-437 wrote: This line seems wrongly indented, should be only two spaces more than the if line: if (check_for_bare_parameter_packs (expression)) expression = error_mark_node; The patch LGTM other

Re: [PATCH] c++: ICE with unexpanded pack in asm

2025-06-13 Thread Marek Polacek
On Wed, Jun 04, 2025 at 09:18:45PM +0800, yxj-github-437 wrote: > > This line seems wrongly indented, should be only two spaces more > > than the if line: > > > > if (check_for_bare_parameter_packs (expression)) > >expression = error_mark_node; > > > > > > The patch LGTM otherwise, thanks. >

Re: [PATCH] c++: ICE with unexpanded pack in asm

2025-06-04 Thread yxj-github-437
> This line seems wrongly indented, should be only two spaces more > than the if line: > > if (check_for_bare_parameter_packs (expression)) >expression = error_mark_node; > > > The patch LGTM otherwise, thanks. Thanks for your reply! The wrongly indented line has been fixed. Please check the

Re: [PATCH] c++: ICE with unexpanded pack in asm

2025-06-03 Thread Marek Polacek
On Wed, Jun 04, 2025 at 01:28:39AM +0800, yxj-github-437 wrote: > Here an unexpanded parameter pack pass into asm_operand which doesn't > expect to see an operand without type. So use check_for_bare_parameter_packs > to remedy that. > > gcc/cp/ChangeLog: > > * parse.cc (cp_parser_asm_operan