Re: [PATCH] c++: Diagnose a deduction guide in a wrong scope [PR91759]

2020-03-17 Thread Jason Merrill via Gcc-patches
On 3/17/20 5:06 PM, Jakub Jelinek wrote: On Tue, Mar 17, 2020 at 03:54:57PM -0400, Jason Merrill via Gcc-patches wrote: How about always diagnosing this here, and moving the deduction guide code in grokfndecl up above set_decl_namespace to avoid a duplicate diagnostic? I've tried that as: ---

Re: [PATCH] c++: Diagnose a deduction guide in a wrong scope [PR91759]

2020-03-17 Thread Jakub Jelinek via Gcc-patches
On Tue, Mar 17, 2020 at 03:54:57PM -0400, Jason Merrill via Gcc-patches wrote: > How about always diagnosing this here, and moving the deduction guide code > in grokfndecl up above set_decl_namespace to avoid a duplicate diagnostic? I've tried that as: --- gcc/cp/decl.c.jj2020-03-16 22:56:46.7

Re: [PATCH] c++: Diagnose a deduction guide in a wrong scope [PR91759]

2020-03-17 Thread Jason Merrill via Gcc-patches
On 3/17/20 4:49 AM, Jakub Jelinek wrote: Hi! The following testcase is accepts-invalid since r7-6608-ga56c0ac08242269b. Before that change we had this "deduction guide %qD must be declared in the same scope as %qT" diagnostics for it, after the change it is expected to be diagnosed in set_decl_n