Re: [PATCH] asan unit tests from llvm lit-test incremental changes

2012-12-13 Thread Jakub Jelinek
On Thu, Dec 13, 2012 at 02:22:52PM +0400, Konstantin Serebryany wrote: > I've added two flags, both on by default for now. > > // Use fast (frame-pointer-based) unwinder on fatal errors (if available). > bool fast_unwind_on_fatal; > // Use fast (frame-pointer-based) unwinder on malloc/free (

Re: [PATCH] asan unit tests from llvm lit-test incremental changes

2012-12-13 Thread Konstantin Serebryany
I've added two flags, both on by default for now. // Use fast (frame-pointer-based) unwinder on fatal errors (if available). bool fast_unwind_on_fatal; // Use fast (frame-pointer-based) unwinder on malloc/free (if available). bool fast_unwind_on_malloc; % clang -fsanitize=address -g ~/ll

Re: [PATCH] asan unit tests from llvm lit-test incremental changes

2012-12-13 Thread Jakub Jelinek
On Thu, Dec 13, 2012 at 11:44:12AM +0400, Konstantin Serebryany wrote: > We are discussing it from time to time. > Sometimes, if e.g. an error happens inside a qsort callback, > the fp-based unwinder fails to unwind through libc, while _Unwind would work. > > I was opposed to this sometime ago bec

Re: [PATCH] asan unit tests from llvm lit-test incremental changes

2012-12-12 Thread Konstantin Serebryany
On Thu, Dec 13, 2012 at 1:30 AM, Jakub Jelinek wrote: > On Wed, Dec 12, 2012 at 10:16:49PM +0100, Dodji Seketeli wrote: >> Independently of this review, I think it's be interesting to hear >> Kostya's voice on: >> >> Jakub Jelinek writes: >> >> > 2) In large-func-test-1.C, I had to stop matching

Re: [PATCH] asan unit tests from llvm lit-test incremental changes

2012-12-12 Thread Dodji Seketeli
Hello, Independently of this review, I think it's be interesting to hear Kostya's voice on: Jakub Jelinek writes: > 2) In large-func-test-1.C, I had to stop matching the backtrace after > _Znw[jm], because libasan is using the fast but inaccurate backtrace, > and while the tests can be easily t

Re: [PATCH] asan unit tests from llvm lit-test incremental changes

2012-12-12 Thread Jakub Jelinek
On Wed, Dec 12, 2012 at 10:16:49PM +0100, Dodji Seketeli wrote: > Independently of this review, I think it's be interesting to hear > Kostya's voice on: > > Jakub Jelinek writes: > > > 2) In large-func-test-1.C, I had to stop matching the backtrace after > > _Znw[jm], because libasan is using th