Re: [PATCH] arc: Add --with-fpu support for ARCv2 cpus

Thanks a lot guys. Patch is pushed. //Claudiu On Mon, Jun 14, 2021 at 12:34 AM Jeff Law wrote: > > > > On 6/13/2021 4:06 AM, Bernhard Reutner-Fischer wrote: > > On Fri, 11 Jun 2021 14:25:24 +0300 > > Claudiu Zissulescu wrote: > > > >> Hi Bernhard, > >> > >> Please find attached my latest patch,

Re: [PATCH] arc: Add --with-fpu support for ARCv2 cpus

On 6/13/2021 4:06 AM, Bernhard Reutner-Fischer wrote: On Fri, 11 Jun 2021 14:25:24 +0300 Claudiu Zissulescu wrote: Hi Bernhard, Please find attached my latest patch, it includes (hopefully) all your feedback. Thank you for comments, concise and clean, i wouldn't know what to remove. LGTM

Re: [PATCH] arc: Add --with-fpu support for ARCv2 cpus

On Fri, 11 Jun 2021 14:25:24 +0300 Claudiu Zissulescu wrote: > Hi Bernhard, > > Please find attached my latest patch, it includes (hopefully) all your > feedback. > > Thank you for comments, concise and clean, i wouldn't know what to remove. LGTM. thanks for your patience!

Re: [PATCH] arc: Add --with-fpu support for ARCv2 cpus

Hi Bernhard, Please find attached my latest patch, it includes (hopefully) all your feedback. Thank you for comments, Claudiu >From 03075b3d9194120d7adb3cdc2aa0f58e3ea9dd1d Mon Sep 17 00:00:00 2001 From: Claudiu Zissulescu Date: Wed, 21 Oct 2020 16:11:43 +0300 Subject: [PATCH] arc: Add --with

Re: [PATCH] arc: Add --with-fpu support for ARCv2 cpus

On 6/9/2021 6:26 AM, Bernhard Reutner-Fischer wrote: On Wed, 9 Jun 2021 14:35:01 +0300 Claudiu Zissulescu wrote: ISTM you only set the expected flags in the switch so i would have set only that variable and have grepped only once after the switch for brevity. ARC has various FPU extensions

Re: [PATCH] arc: Add --with-fpu support for ARCv2 cpus

On Wed, 9 Jun 2021 14:35:01 +0300 Claudiu Zissulescu wrote: > > ISTM you only set the expected flags in the switch so i would have > > set only that variable and have grepped only once after the switch for > > brevity. > > ARC has various FPU extensions, some of them are common to EM and HS >

Re: [PATCH] arc: Add --with-fpu support for ARCv2 cpus

Hi, I would have written [[:space:]]* instead of [[:space:]]+ to handle potentially missing space, at least after the comma but also before the comma to avoid surprises for new names in the future. Furthermore | alone would be [[:blank:]]* but as you prefer. grep ... > /dev/null would be grep -

Re: [PATCH] arc: Add --with-fpu support for ARCv2 cpus

On Tue, 8 Jun 2021 10:05:28 +0300 Claudiu Zissulescu wrote: > Thank you for your input. > > I have made an update using grep's ERE. Please let me know if it is ok. I would have written [[:space:]]* instead of [[:space:]]+ to handle potentially missing space, at least after the comma but also be

Re: [PATCH] arc: Add --with-fpu support for ARCv2 cpus

Thank you for your input. I have made an update using grep's ERE. Please let me know if it is ok. //Claudiu >From 3f598e0fc9bc88c3f40f3e381c2955ab36e77ce0 Mon Sep 17 00:00:00 2001 From: Claudiu Zissulescu Date: Wed, 21 Oct 2020 16:11:43 +0300 Subject: [PATCH] arc: Add --with-fpu support for ARC

Re: [PATCH] arc: Add --with-fpu support for ARCv2 cpus

On 6/4/2021 1:29 AM, Claudiu Zissulescu via Gcc-patches wrote: Hi Jeff, I would like to add spport for selecting the ARCv2 FPU extension at configuration-time. The --with-fpu configuration option is ignored when -mfpu compiler option is specified. My concern is using `grep -P` when configur

Re: [PATCH] arc: Add --with-fpu support for ARCv2 cpus

On Fri, 4 Jun 2021 10:29:09 +0300 Claudiu Zissulescu via Gcc-patches wrote: > Hi Jeff, > > I would like to add spport for selecting the ARCv2 FPU extension at > configuration-time. > > The --with-fpu configuration option is ignored when -mfpu compiler > option is specified. > > My concern is