Re: [PATCH] amdgcn: Add stub personality function

2020-04-23 Thread Andrew Stubbs
On 23/04/2020 12:21, Kwok Cheung Yeung wrote: I agree that not generating the problematic code in the first place is the better approach. Does that mean we can now remove libgcc/config/gcn/unwind-gcn.c completely? That was added for the benefit of libgfortran, not C++. It's used by the backtr

Re: [PATCH] amdgcn: Add stub personality function

2020-04-23 Thread Kwok Cheung Yeung
On 23/04/2020 12:05 pm, Thomas Schwinge wrote: So we should simply disable it properly (see below)... ... instead of adding such stub functions. I suggest we instead apply what I'd proposed a month ago in "[amdgcn] ld: error: undefined symbol: __gxx_personality_v0

Re: [PATCH] amdgcn: Add stub personality function

2020-04-23 Thread Thomas Schwinge
Hi! On 2020-04-23T09:15:29+0100, Andrew Stubbs wrote: > On 22/04/2020 22:10, Kwok Cheung Yeung wrote: >> This patch adds a stub implementation of __gxx_personality_v0, which is >> used in C++ exception handling. AMD GCN currently does not actually >> support exception handling So we should simpl

Re: [PATCH] amdgcn: Add stub personality function

2020-04-23 Thread Andrew Stubbs
On 22/04/2020 22:10, Kwok Cheung Yeung wrote: Hello This patch adds a stub implementation of __gxx_personality_v0, which is used in C++ exception handling. AMD GCN currently does not actually support exception handling (the unwind functions are all stubs too), so adding an extra stub function