Thanks for applying the patch. Backported to google-4_8
I still have some concern when inlining .part function into its
original function: basically, the gimple_block for that call may be
NULL, but it does not make sense to clear all block info for all stmts
in the .part function.
Dehao
On Tue,
>> Can someone comment / approve it quickly so that we get AArch32 and AArch64
>> linux cross-builds back up ?
>
> Ok.
Applied for Dehao as r203269 . Tests on arm came back ok.
Ramana
>
> Thanks,
> Richard.
>
>>
>> regards
>> Ramana
>>
>>>
>>> Honza
>>>
Dehao
>
> Honza
>>>
On Mon, Oct 7, 2013 at 12:02 PM, Ramana Radhakrishnan wrote:
> On 10/04/13 22:23, Jan Hubicka wrote:
>>>
>>> On Fri, Oct 4, 2013 at 11:54 AM, Jan Hubicka wrote:
>
> I looked at this problem. Bug updated
> http://gcc.gnu.org/bugzilla/show_bug.cgi?id=58619
>
> This is a bug when
On 10/04/13 22:23, Jan Hubicka wrote:
On Fri, Oct 4, 2013 at 11:54 AM, Jan Hubicka wrote:
I looked at this problem. Bug updated
http://gcc.gnu.org/bugzilla/show_bug.cgi?id=58619
This is a bug when updating block during tree-inline. Basically, it is
legal for *n to be NULL. E.g. When gimple_blo
> On Fri, Oct 4, 2013 at 11:54 AM, Jan Hubicka wrote:
> >> I looked at this problem. Bug updated
> >> http://gcc.gnu.org/bugzilla/show_bug.cgi?id=58619
> >>
> >> This is a bug when updating block during tree-inline. Basically, it is
> >> legal for *n to be NULL. E.g. When gimple_block(id->gimple_c
On Fri, Oct 4, 2013 at 11:54 AM, Jan Hubicka wrote:
>> I looked at this problem. Bug updated
>> http://gcc.gnu.org/bugzilla/show_bug.cgi?id=58619
>>
>> This is a bug when updating block during tree-inline. Basically, it is
>> legal for *n to be NULL. E.g. When gimple_block(id->gimple_call) is
>> N
> I looked at this problem. Bug updated
> http://gcc.gnu.org/bugzilla/show_bug.cgi?id=58619
>
> This is a bug when updating block during tree-inline. Basically, it is
> legal for *n to be NULL. E.g. When gimple_block(id->gimple_call) is
> NULL, remap_blocks_to_null will be called to set *n to NULL
I looked at this problem. Bug updated
http://gcc.gnu.org/bugzilla/show_bug.cgi?id=58619
This is a bug when updating block during tree-inline. Basically, it is
legal for *n to be NULL. E.g. When gimple_block(id->gimple_call) is
NULL, remap_blocks_to_null will be called to set *n to NULL.
The probl
My change on the probability of builtin_expect does have an impact on
the partial inline (more outlined functions will get inline back to
the original function).
I think this triggers an existing issue.
Dehao will explain this in his coming email.
-Rong
On Fri, Oct 4, 2013 at 6:05 AM, Ramana Radh
Dehao, can you take a look?
David
On Fri, Oct 4, 2013 at 6:05 AM, Ramana Radhakrishnan wrote:
> On 10/02/13 23:49, Rong Xu wrote:
>>
>> Here is the new patch. Honaz: Could you take a look?
>>
>> Thanks,
>>
>> -Rong
>>
>> On Wed, Oct 2, 2013 at 2:31 PM, Jan Hubicka wrote:
Thanks for th
On 10/02/13 23:49, Rong Xu wrote:
Here is the new patch. Honaz: Could you take a look?
Thanks,
-Rong
On Wed, Oct 2, 2013 at 2:31 PM, Jan Hubicka wrote:
Thanks for the suggestion. This is much cleaner than to use binary parameter.
Just want to make sure I understand it correctly about the or
> Here is the new patch. Honaz: Could you take a look?
OK, thanks!
Honza
Here is the new patch. Honaz: Could you take a look?
Thanks,
-Rong
On Wed, Oct 2, 2013 at 2:31 PM, Jan Hubicka wrote:
>> Thanks for the suggestion. This is much cleaner than to use binary parameter.
>>
>> Just want to make sure I understand it correctly about the orginal hitrate:
>> you want to
> Thanks for the suggestion. This is much cleaner than to use binary parameter.
>
> Just want to make sure I understand it correctly about the orginal hitrate:
> you want to retire the hitrate in PRED_BUILTIN_EXPECT and always use
> the one specified in the biniltin-expect-probability parameter.
On Wed, Oct 2, 2013 at 9:08 AM, Jan Hubicka wrote:
>> > Hi,
>> >
>> >
>> >
>> > Current default probability for builtin_expect is 0.9996.
>> > This makes the freq of unlikely bb very low (4), which
>> > suppresses the inlining of any calls within those bb.
>> >
>> > We used FDO data to measure t
> > Hi,
> >
> >
> >
> > Current default probability for builtin_expect is 0.9996.
> > This makes the freq of unlikely bb very low (4), which
> > suppresses the inlining of any calls within those bb.
> >
> > We used FDO data to measure the branch probably for
> > the branch annotated with builtin_
ping.
On Fri, Sep 27, 2013 at 3:53 PM, Rong Xu wrote:
> Hi,
>
>
>
> Current default probability for builtin_expect is 0.9996.
> This makes the freq of unlikely bb very low (4), which
> suppresses the inlining of any calls within those bb.
>
> We used FDO data to measure the branch probably for
17 matches
Mail list logo
