Re: [PATCH] Use secure_getenv for GOMP_DEBUG

2017-07-03 Thread Tom de Vries
On 07/03/2017 02:26 PM, Franz Sirl wrote: Am 27.06.17 um 13:10 schrieb Tom de Vries: --- a/libgomp/plugin/plugin-hsa.c +++ b/libgomp/plugin/plugin-hsa.c @@ -39,32 +39,7 @@ #include #include "libgomp-plugin.h" #include "gomp-constants.h" - -/* Secure getenv() which returns NULL if running

Re: [PATCH] Use secure_getenv for GOMP_DEBUG

2017-07-03 Thread Franz Sirl
Am 27.06.17 um 13:10 schrieb Tom de Vries: --- a/libgomp/plugin/plugin-hsa.c +++ b/libgomp/plugin/plugin-hsa.c @@ -39,32 +39,7 @@ #include #include "libgomp-plugin.h" #include "gomp-constants.h" - -/* Secure getenv() which returns NULL if running as SUID/SGID. */ -#ifndef HAVE_SECURE_GETE

Re: [PATCH] Use secure_getenv for GOMP_DEBUG

2017-06-27 Thread Jakub Jelinek
On Tue, Jun 27, 2017 at 01:10:19PM +0200, Tom de Vries wrote: > +/* Secure getenv() which returns NULL if running as SUID/SGID. */ > +#ifndef HAVE_SECURE_GETENV > +#if defined (HAVE_UNISTD_H) && defined(HAVE_GETUID) && defined(HAVE_GETEUID) > \ > + && defined(HAVE_GETGID) && defined(HAVE_GETEGID

Re: [PATCH] Use secure_getenv for GOMP_DEBUG

2017-06-27 Thread Tom de Vries
On 06/27/2017 09:38 AM, Jakub Jelinek wrote: On Tue, Jun 27, 2017 at 09:17:57AM +0200, Tom de Vries wrote: This patch uses secure_getenv for GOMP_DEBUG. It factors out the secure_getenv code from plugin-hsa.c into libgomp/secure_getenv.h, and reuses it in env.c. I've added _GNU_SOURCE before t

Re: [PATCH] Use secure_getenv for GOMP_DEBUG

2017-06-27 Thread Jakub Jelinek
On Tue, Jun 27, 2017 at 09:17:57AM +0200, Tom de Vries wrote: > This patch uses secure_getenv for GOMP_DEBUG. > > It factors out the secure_getenv code from plugin-hsa.c into > libgomp/secure_getenv.h, and reuses it in env.c. > > I've added _GNU_SOURCE before the libgomp.h include in env.c to mak