Re: [PATCH] Use dump_asm_name for Callers/Calls in dump.

2020-01-08 Thread Martin Liška
On 1/8/20 11:08 AM, Jan Hubicka wrote: On 1/7/20 11:27 AM, Martin Liška wrote: Which is fine. Apparently there are just few usages of manual printing of a symtab node and order like:   fprintf (f,    "%*s%s/%i %s\n%*s  freq:%4.2f",    indent, "", callee->name (), calle

Re: [PATCH] Use dump_asm_name for Callers/Calls in dump.

2020-01-08 Thread Jan Hubicka
> On 1/7/20 11:27 AM, Martin Liška wrote: > > Which is fine. Apparently there are just few usages of manual printing > > of a symtab node and order like: > > > >   fprintf (f, > >    "%*s%s/%i %s\n%*s  freq:%4.2f", > >    indent, "", callee->name (), callee->order, > > > >

Re: [PATCH] Use dump_asm_name for Callers/Calls in dump.

2020-01-08 Thread Martin Liška
On 1/7/20 11:27 AM, Martin Liška wrote: Which is fine. Apparently there are just few usages of manual printing of a symtab node and order like:   fprintf (f,    "%*s%s/%i %s\n%*s  freq:%4.2f",    indent, "", callee->name (), callee->order, I can replace these with symtab_

Re: [PATCH] Use dump_asm_name for Callers/Calls in dump.

2020-01-07 Thread Martin Liška
On 1/7/20 11:12 AM, Martin Jambor wrote: I try to use just the symtab_order numbers whenever I can to avoid confusion Which is fine. Apparently there are just few usages of manual printing of a symtab node and order like: fprintf (f, "%*s%s/%i %s\n%*s freq:%4.2f",

Re: [PATCH] Use dump_asm_name for Callers/Calls in dump.

2020-01-07 Thread Martin Jambor
Hi, On Tue, Jan 07 2020, Martin Liška wrote: > Hi. > > I would like to make cgraph_node names consistent in cgraph_node::dump. > I try to use just the symtab_order numbers whenever I can to avoid confusion but - at least if we care about the non-asm name at all - shouldn't the dump have both the