Re: [PATCH] Teach mklog to reference PRs.

2019-08-12 Thread Pedro Alves
On 8/12/19 8:34 PM, Pedro Alves wrote: > Let me share my 2c -- the format GDB uses doesn't affect most GCC forks I meant most GCC folks. Thanks, Pedro Alves

Re: [PATCH] Teach mklog to reference PRs.

2019-08-12 Thread Pedro Alves
On 8/1/19 4:01 PM, Jakub Jelinek wrote: > You can easily tweak the script to handle the other way too. > Looking around, different people have different style, some people don't > post the date/name/email lines at all, others do, some people post them > multiple times, once for each ChangeLog, othe

Re: [PATCH] Teach mklog to reference PRs.

2019-08-12 Thread Marek Polacek
On Mon, Aug 12, 2019 at 10:27:46AM -0600, Martin Sebor wrote: > FWIW, another feature I find useful that mklog doesn't seem to have > is one that strips the context details from testsuite ChangeLogs. > Hardly anyone bothers to mention the functions, macros, types, or > variables they changed in tes

Re: [PATCH] Teach mklog to reference PRs.

2019-08-12 Thread Martin Sebor
On 8/2/19 12:04 AM, Martin Liška wrote: On 8/2/19 7:45 AM, Martin Liška wrote: I agree with that approach. I'm sending an example how it would look like for something bigger: $ git diff e8a3be407068bfb9c82f0f6656b30d26cc2f484a~15..e8a3be407068bfb9c82f0f6656b30d26cc2f484a > patch && ./contri

Re: [PATCH] Teach mklog to reference PRs.

2019-08-12 Thread Martin Liška
On 8/2/19 8:04 AM, Martin Liška wrote: > On 8/2/19 7:45 AM, Martin Liška wrote: >> I agree with that approach. > > I'm sending an example how it would look like for something > bigger: > > $ git diff > e8a3be407068bfb9c82f0f6656b30d26cc2f484a~15..e8a3be407068bfb9c82f0f6656b30d26cc2f484a > > pat

Re: [PATCH] Teach mklog to reference PRs.

2019-08-02 Thread Martin Liška
On 8/2/19 10:54 AM, Jakub Jelinek wrote: > On Fri, Aug 02, 2019 at 10:48:55AM +0200, Martin Liška wrote: >>> Just a nit, some lines are too long and perhaps mklog could be improved too. >>> On the first line above, one would normally wrap it as: >>> * testsuite/23_containers/array/comparison_op

Re: [PATCH] Teach mklog to reference PRs.

2019-08-02 Thread Jakub Jelinek
On Fri, Aug 02, 2019 at 10:48:55AM +0200, Martin Liška wrote: > > Just a nit, some lines are too long and perhaps mklog could be improved too. > > On the first line above, one would normally wrap it as: > > * testsuite/23_containers/array/comparison_operators/constexpr.cc: > > New test. > >

Re: [PATCH] Teach mklog to reference PRs.

2019-08-02 Thread Martin Liška
On 8/2/19 9:48 AM, Jakub Jelinek wrote: > On Fri, Aug 02, 2019 at 08:04:11AM +0200, Martin Liška wrote: >> On 8/2/19 7:45 AM, Martin Liška wrote: >>> I agree with that approach. >> >> I'm sending an example how it would look like for something >> bigger: >> >> $ git diff >> e8a3be407068bfb9c82f0f6

Re: [PATCH] Teach mklog to reference PRs.

2019-08-02 Thread Jakub Jelinek
On Fri, Aug 02, 2019 at 08:04:11AM +0200, Martin Liška wrote: > On 8/2/19 7:45 AM, Martin Liška wrote: > > I agree with that approach. > > I'm sending an example how it would look like for something > bigger: > > $ git diff > e8a3be407068bfb9c82f0f6656b30d26cc2f484a~15..e8a3be407068bfb9c82f0f665

Re: [PATCH] Teach mklog to reference PRs.

2019-08-01 Thread Martin Liška
On 8/2/19 7:45 AM, Martin Liška wrote: > I agree with that approach. I'm sending an example how it would look like for something bigger: $ git diff e8a3be407068bfb9c82f0f6656b30d26cc2f484a~15..e8a3be407068bfb9c82f0f6656b30d26cc2f484a > patch && ./contrib/mklog patch > changelog.txt Thoughts?

Re: [PATCH] Teach mklog to reference PRs.

2019-08-01 Thread Martin Liška
On 8/1/19 5:01 PM, Jakub Jelinek wrote: > On Thu, Aug 01, 2019 at 04:37:40PM +0200, Martin Liška wrote: >>> OT I'm actually quite annoyed by mklog repeating the date/name/email >>> for each changelog, I'd find it much more natural to print that and the >>> list of PRs once and then just those contr

Re: [PATCH] Teach mklog to reference PRs.

2019-08-01 Thread Jakub Jelinek
On Thu, Aug 01, 2019 at 04:37:40PM +0200, Martin Liška wrote: > > OT I'm actually quite annoyed by mklog repeating the date/name/email > > for each changelog, I'd find it much more natural to print that and the > > list of PRs once and then just those contrib/, gcc/testsuite/ etc. > > snippets with

Re: [PATCH] Teach mklog to reference PRs.

2019-08-01 Thread Martin Liška
On 8/1/19 3:26 PM, Jakub Jelinek wrote: > On Thu, Aug 01, 2019 at 03:09:22PM +0200, Martin Liška wrote: >> Hi. >> >> I use quite often mklog and then I manually write references >> to PRs. I would like to teach the script to do it for me. >> Example: >> >> $ ./contrib/mklog /tmp/patch -b lto/91307,

Re: [PATCH] Teach mklog to reference PRs.

2019-08-01 Thread Jakub Jelinek
On Thu, Aug 01, 2019 at 03:09:22PM +0200, Martin Liška wrote: > Hi. > > I use quite often mklog and then I manually write references > to PRs. I would like to teach the script to do it for me. > Example: > > $ ./contrib/mklog /tmp/patch -b lto/91307,c/12345 > /tmp/changelog > $ cat /tmp/changelog