Re: [PATCH] S/390: Initial libitm support

2013-04-22 Thread Andreas Krebbel
On 22/04/13 18:13, Richard Henderson wrote: > On 2013-04-22 09:23, Andreas Krebbel wrote: >> + /* We save registers 6-15. */ >> + long int __gregs[9]; > > Comment should be r6-r14, surely. > >> + /* r15 is stored into cfa field. It needs to be named that way >> + since tls.h is acces

Re: [PATCH] S/390: Initial libitm support

2013-04-22 Thread Richard Henderson
On 2013-04-22 09:23, Andreas Krebbel wrote: + /* We save registers 6-15. */ + long int __gregs[9]; Comment should be r6-r14, surely. + /* r15 is stored into cfa field. It needs to be named that way + since tls.h is accessing the field by name. Be aware that this + is not ac