Re: [PATCH] S/390: Fix conditional returns

2018-09-19 Thread Segher Boessenkool
On Tue, Sep 18, 2018 at 10:15:00PM -0600, Jeff Law wrote: > On 9/18/18 8:04 AM, Segher Boessenkool wrote: > > On Wed, Sep 05, 2018 at 10:34:48AM +0200, Ilya Leoshkevich wrote: > >> S/390 epilogue ends with (parallel [(return) (use %r14)]) instead of > >> the more usual (return) or (simple_return).

Re: [PATCH] S/390: Fix conditional returns

2018-09-19 Thread Ilya Leoshkevich
> Am 19.09.2018 um 06:15 schrieb Jeff Law : > > On 9/18/18 8:04 AM, Segher Boessenkool wrote: >> On Wed, Sep 05, 2018 at 10:34:48AM +0200, Ilya Leoshkevich wrote: >>> S/390 epilogue ends with (parallel [(return) (use %r14)]) instead of >>> the more usual (return) or (simple_return). This sequence

Re: [PATCH] S/390: Fix conditional returns

2018-09-18 Thread Jeff Law
On 9/18/18 8:04 AM, Segher Boessenkool wrote: > On Wed, Sep 05, 2018 at 10:34:48AM +0200, Ilya Leoshkevich wrote: >> S/390 epilogue ends with (parallel [(return) (use %r14)]) instead of >> the more usual (return) or (simple_return). This sequence is not >> recognized by the conditional return logi

Re: [PATCH] S/390: Fix conditional returns

2018-09-18 Thread Segher Boessenkool
On Wed, Sep 05, 2018 at 10:34:48AM +0200, Ilya Leoshkevich wrote: > S/390 epilogue ends with (parallel [(return) (use %r14)]) instead of > the more usual (return) or (simple_return). This sequence is not > recognized by the conditional return logic in try_optimize_cfg (). Why does it need this?

Re: [PATCH] S/390: Fix conditional returns

2018-09-18 Thread Ilya Leoshkevich
> Am 18.09.2018 um 02:57 schrieb Jeff Law : > > On 9/5/18 2:34 AM, Ilya Leoshkevich wrote: >> --- a/gcc/cfgcleanup.c >> +++ b/gcc/cfgcleanup.c >> @@ -2624,7 +2624,7 @@ bb_is_just_return (basic_block bb, rtx_insn **ret, >> rtx_insn **use) >> { >> rtx pat = PATTERN (insn); >> >> -if

Re: [PATCH] S/390: Fix conditional returns

2018-09-17 Thread Jeff Law
On 9/5/18 2:34 AM, Ilya Leoshkevich wrote: > S/390 epilogue ends with (parallel [(return) (use %r14)]) instead of > the more usual (return) or (simple_return). This sequence is not > recognized by the conditional return logic in try_optimize_cfg (). > > gcc/ChangeLog: > > 2018-08-28 Ilya Leoshk

Re: [PATCH] S/390: Fix conditional returns

2018-09-06 Thread Andreas Krebbel
Hi Ilya, the S/390 parts look good to me. For the rest we will need approval from a middle-end maintainer. Andreas On 05.09.2018 10:34, Ilya Leoshkevich wrote: > S/390 epilogue ends with (parallel [(return) (use %r14)]) instead of > the more usual (return) or (simple_return). This sequence is