Re: [PATCH] Reset relations when crossing backedges.

2022-03-21 Thread Richard Biener via Gcc-patches
On Sat, Mar 19, 2022 at 8:27 PM Jeff Law wrote: > > > > On 2/2/2022 2:27 AM, Richard Biener wrote: > > On Tue, Feb 1, 2022 at 7:41 PM Aldy Hernandez wrote: > >> Ping > > I didn't quite get Jeffs comment, so I waited (sorry). I've meanwhile added > Sorry. IIRC the concern was whether or not we n

Re: [PATCH] Reset relations when crossing backedges.

2022-03-19 Thread Jeff Law via Gcc-patches
On 2/2/2022 2:27 AM, Richard Biener wrote: On Tue, Feb 1, 2022 at 7:41 PM Aldy Hernandez wrote: Ping I didn't quite get Jeffs comment, so I waited (sorry). I've meanwhile added Sorry.  IIRC the concern was whether or not we need to do something special for irreducible regions.  In that ca

Re: [PATCH] Reset relations when crossing backedges.

2022-02-09 Thread Martin Jambor
Hello, On Fri, Jan 21 2022, Aldy Hernandez via Gcc-patches wrote: > As discussed in PR103721, the problem here is that we are crossing a > backedge and causing us to use relations from a previous iteration of a > loop. > > This handles the testcases in both PR103721 and PR104067 which are variants

Re: [PATCH] Reset relations when crossing backedges.

2022-02-02 Thread Richard Biener via Gcc-patches
On Tue, Feb 1, 2022 at 7:41 PM Aldy Hernandez wrote: > > Ping I didn't quite get Jeffs comment, so I waited (sorry). I've meanwhile added extern bool mark_dfs_back_edges (struct function *); so please make verify_mark_backedges take a struct function * and replace 'cfun' with the explicit argu

Re: [PATCH] Reset relations when crossing backedges.

2022-02-01 Thread Aldy Hernandez via Gcc-patches
Ping On Mon, Jan 24, 2022, 20:20 Aldy Hernandez wrote: > On Mon, Jan 24, 2022 at 9:51 AM Richard Biener > wrote: > > > > On Fri, Jan 21, 2022 at 1:12 PM Aldy Hernandez wrote: > > > > > > On Fri, Jan 21, 2022 at 11:56 AM Richard Biener > > > wrote: > > > > > > > > On Fri, Jan 21, 2022 at 11:30

Re: [PATCH] Reset relations when crossing backedges.

2022-01-24 Thread Jeff Law via Gcc-patches
On 1/21/2022 3:29 AM, Aldy Hernandez wrote: On Fri, Jan 21, 2022 at 10:43 AM Richard Biener wrote: On Fri, Jan 21, 2022 at 9:30 AM Aldy Hernandez via Gcc-patches wrote: As discussed in PR103721, the problem here is that we are crossing a backedge and causing us to use relations from a prev

Re: [PATCH] Reset relations when crossing backedges.

2022-01-24 Thread Aldy Hernandez via Gcc-patches
On Mon, Jan 24, 2022 at 9:51 AM Richard Biener wrote: > > On Fri, Jan 21, 2022 at 1:12 PM Aldy Hernandez wrote: > > > > On Fri, Jan 21, 2022 at 11:56 AM Richard Biener > > wrote: > > > > > > On Fri, Jan 21, 2022 at 11:30 AM Aldy Hernandez wrote: > > > > > > > > On Fri, Jan 21, 2022 at 10:43 AM

Re: [PATCH] Reset relations when crossing backedges.

2022-01-24 Thread Richard Biener via Gcc-patches
On Fri, Jan 21, 2022 at 1:12 PM Aldy Hernandez wrote: > > On Fri, Jan 21, 2022 at 11:56 AM Richard Biener > wrote: > > > > On Fri, Jan 21, 2022 at 11:30 AM Aldy Hernandez wrote: > > > > > > On Fri, Jan 21, 2022 at 10:43 AM Richard Biener > > > wrote: > > > > > > > > On Fri, Jan 21, 2022 at 9:30

Re: [PATCH] Reset relations when crossing backedges.

2022-01-21 Thread Aldy Hernandez via Gcc-patches
On Fri, Jan 21, 2022 at 11:56 AM Richard Biener wrote: > > On Fri, Jan 21, 2022 at 11:30 AM Aldy Hernandez wrote: > > > > On Fri, Jan 21, 2022 at 10:43 AM Richard Biener > > wrote: > > > > > > On Fri, Jan 21, 2022 at 9:30 AM Aldy Hernandez via Gcc-patches > > > wrote: > > > > > > > > As discuss

Re: [PATCH] Reset relations when crossing backedges.

2022-01-21 Thread Richard Biener via Gcc-patches
On Fri, Jan 21, 2022 at 11:30 AM Aldy Hernandez wrote: > > On Fri, Jan 21, 2022 at 10:43 AM Richard Biener > wrote: > > > > On Fri, Jan 21, 2022 at 9:30 AM Aldy Hernandez via Gcc-patches > > wrote: > > > > > > As discussed in PR103721, the problem here is that we are crossing a > > > backedge an

Re: [PATCH] Reset relations when crossing backedges.

2022-01-21 Thread Aldy Hernandez via Gcc-patches
On Fri, Jan 21, 2022 at 10:43 AM Richard Biener wrote: > > On Fri, Jan 21, 2022 at 9:30 AM Aldy Hernandez via Gcc-patches > wrote: > > > > As discussed in PR103721, the problem here is that we are crossing a > > backedge and causing us to use relations from a previous iteration of a > > loop. > >

Re: [PATCH] Reset relations when crossing backedges.

2022-01-21 Thread Richard Biener via Gcc-patches
On Fri, Jan 21, 2022 at 9:30 AM Aldy Hernandez via Gcc-patches wrote: > > As discussed in PR103721, the problem here is that we are crossing a > backedge and causing us to use relations from a previous iteration of a > loop. > > This handles the testcases in both PR103721 and PR104067 which are va