Re: [PATCH] Remove unused code.

2018-07-20 Thread Richard Biener
On Fri, Jul 20, 2018 at 10:52 AM Martin Liška wrote: > > Hi. > > Following was introduced in r230331 and as David confirmed > it was installed accidentally. It has never been used. > > Ready for trunk? OK > Martin > > gcc/ChangeLog: > > 2018-07-20 Martin Liska > > * tree.h (DECL_LOCATI

Re: [patch] Remove unused code from dse.c.

2013-03-30 Thread Lawrence Crowl
On 3/29/13, Jeff Law wrote: > More correctly, it's been dead since an Oct 2008 patch from > Richard Henderson which introduced set_mem_attrs_for_spill which > effectively provides the alias analysis code with the information > it needs to disambiguate stack slots from everything else without > the

Re: [patch] Remove unused code from dse.c.

2013-03-29 Thread Jeff Law
On 03/29/2013 12:12 PM, Steven Bosscher wrote: On Fri, Mar 29, 2013 at 6:29 PM, Jeff Law wrote: On 03/29/2013 11:24 AM, Lawrence Crowl wrote: At what point did we stop setting clear_alias_sets? Was that intentional or not? I do not know the answer to either question. That's what needs t

Re: [patch] Remove unused code from dse.c.

2013-03-29 Thread Steven Bosscher
On Fri, Mar 29, 2013 at 6:29 PM, Jeff Law wrote: > On 03/29/2013 11:24 AM, Lawrence Crowl wrote: > >>> At what point did we stop setting clear_alias_sets? Was that >>> intentional or not? >> >> >> I do not know the answer to either question. > > That's what needs to be determined before I'll appr

Re: [patch] Remove unused code from dse.c.

2013-03-29 Thread Jeff Law
On 03/29/2013 11:24 AM, Lawrence Crowl wrote: At what point did we stop setting clear_alias_sets? Was that intentional or not? I do not know the answer to either question. That's what needs to be determined before I'll approve. It means digging a bit. My view is that we have already los

Re: [patch] Remove unused code from dse.c.

2013-03-29 Thread Lawrence Crowl
On 3/29/13, Jeff Law wrote: > On 03/29/2013 02:24 AM, Lawrence Crowl wrote: >> This patch has been in the hash-table branch for months. >> I thought it didn't quite meet the criteria for obvious, >> but it's close. >> >> >> In dse.c, remove alias hash tables that are never set. >> Remove condition

Re: [patch] Remove unused code from dse.c.

2013-03-29 Thread Jeff Law
On 03/29/2013 02:24 AM, Lawrence Crowl wrote: This patch has been in the hash-table branch for months. I thought it didn't quite meet the criteria for obvious, but it's close. In dse.c, remove alias hash tables that are never set. Remove conditions that are then never true. Remove functions tha