Re: [PATCH] Refine -Waddress-of-packed-member once more

2019-01-27 Thread Jakub Jelinek
On Fri, Jan 25, 2019 at 06:36:53AM +, Bernd Edlinger wrote: > 2019-01-25 Bernd Edlinger > > * c-warn.c (check_address_or_pointer_of_packed_member): Handle the case > when rhs is of array type correctly. Fix handling of nested structures. > Fix handling of indirect_ref tog

Re: [PATCH] Refine -Waddress-of-packed-member once more

2019-01-24 Thread Bernd Edlinger
On 1/24/19 8:18 AM, Jakub Jelinek wrote: > On Thu, Jan 24, 2019 at 06:39:22AM +, Bernd Edlinger wrote: >> --- gcc/c-family/c-warn.c(revision 268195) >> +++ gcc/c-family/c-warn.c(working copy) >> @@ -2725,14 +2725,18 @@ static tree >> check_address_or_pointer_of_packed_member (tree type

Re: [PATCH] Refine -Waddress-of-packed-member once more

2019-01-23 Thread Jakub Jelinek
On Thu, Jan 24, 2019 at 06:39:22AM +, Bernd Edlinger wrote: > --- gcc/c-family/c-warn.c (revision 268195) > +++ gcc/c-family/c-warn.c (working copy) > @@ -2725,14 +2725,18 @@ static tree > check_address_or_pointer_of_packed_member (tree type, tree rhs) > { >bool rvalue = true; > +

Re: [PATCH] Refine -Waddress-of-packed-member once more

2019-01-23 Thread Bernd Edlinger
On 1/23/19 4:22 PM, Jakub Jelinek wrote: > On Tue, Jan 22, 2019 at 02:10:38PM +, Bernd Edlinger wrote: >> --- gcc/c-family/c-warn.c(revision 268119) >> +++ gcc/c-family/c-warn.c(working copy) >> @@ -2796,6 +2796,10 @@ check_address_or_pointer_of_packed_membe >>if (context) >>

Re: [PATCH] Refine -Waddress-of-packed-member once more

2019-01-23 Thread Bernd Edlinger
On 1/23/19 4:22 PM, Jakub Jelinek wrote: > On Tue, Jan 22, 2019 at 02:10:38PM +, Bernd Edlinger wrote: >> --- gcc/c-family/c-warn.c(revision 268119) >> +++ gcc/c-family/c-warn.c(working copy) >> @@ -2796,6 +2796,10 @@ check_address_or_pointer_of_packed_membe >>if (context) >>

Re: [PATCH] Refine -Waddress-of-packed-member once more

2019-01-23 Thread Jakub Jelinek
On Tue, Jan 22, 2019 at 02:10:38PM +, Bernd Edlinger wrote: > --- gcc/c-family/c-warn.c (revision 268119) > +++ gcc/c-family/c-warn.c (working copy) > @@ -2796,6 +2796,10 @@ check_address_or_pointer_of_packed_membe > if (context) > break; > } > + if (TREE_CO

Re: [PATCH] Refine -Waddress-of-packed-member once more

2019-01-22 Thread H.J. Lu
On Tue, Jan 22, 2019 at 6:10 AM Bernd Edlinger wrote: > > Hi, > > unfortunately there are some more issues with -Waddress-of-packed-member, > that show that my previous > patch was not yet complete. > > That is a bogus warning, in C and C++ (see addition in test case 1), and a > couple of missin