Re: [PATCH] Refactor back_threader_profitability

2022-08-19 Thread Jeff Law via Gcc-patches
On 8/17/2022 1:31 AM, Aldy Hernandez via Gcc-patches wrote: I just have a few high level comments. On Tue, Aug 16, 2022 at 4:05 PM Richard Biener wrote: The following refactors profitable_path_p in the backward threader, splitting out parts that can be computed once the exit block is known,

Re: [PATCH] Refactor back_threader_profitability

2022-08-17 Thread Aldy Hernandez via Gcc-patches
On Wed, Aug 17, 2022 at 10:59 AM Richard Biener wrote: > > On Wed, 17 Aug 2022, Aldy Hernandez wrote: > > > On Wed, Aug 17, 2022 at 10:38 AM Richard Biener wrote: > > > > > > On Wed, 17 Aug 2022, Aldy Hernandez wrote: > > > > > > > On Wed, Aug 17, 2022 at 9:54 AM Richard Biener > > > > wrote: >

Re: [PATCH] Refactor back_threader_profitability

2022-08-17 Thread Richard Biener via Gcc-patches
On Wed, 17 Aug 2022, Aldy Hernandez wrote: > On Wed, Aug 17, 2022 at 10:38 AM Richard Biener wrote: > > > > On Wed, 17 Aug 2022, Aldy Hernandez wrote: > > > > > On Wed, Aug 17, 2022 at 9:54 AM Richard Biener wrote: > > > > > > > > On Wed, 17 Aug 2022, Aldy Hernandez wrote: > > > > > > > > > I ju

Re: [PATCH] Refactor back_threader_profitability

2022-08-17 Thread Aldy Hernandez via Gcc-patches
On Wed, Aug 17, 2022 at 10:38 AM Richard Biener wrote: > > On Wed, 17 Aug 2022, Aldy Hernandez wrote: > > > On Wed, Aug 17, 2022 at 9:54 AM Richard Biener wrote: > > > > > > On Wed, 17 Aug 2022, Aldy Hernandez wrote: > > > > > > > I just have a few high level comments. > > > > > > > > On Tue, Aug

Re: [PATCH] Refactor back_threader_profitability

2022-08-17 Thread Richard Biener via Gcc-patches
On Wed, 17 Aug 2022, Aldy Hernandez wrote: > On Wed, Aug 17, 2022 at 9:54 AM Richard Biener wrote: > > > > On Wed, 17 Aug 2022, Aldy Hernandez wrote: > > > > > I just have a few high level comments. > > > > > > On Tue, Aug 16, 2022 at 4:05 PM Richard Biener wrote: > > > > > > > > The following r

Re: [PATCH] Refactor back_threader_profitability

2022-08-17 Thread Aldy Hernandez via Gcc-patches
On Wed, Aug 17, 2022 at 9:54 AM Richard Biener wrote: > > On Wed, 17 Aug 2022, Aldy Hernandez wrote: > > > I just have a few high level comments. > > > > On Tue, Aug 16, 2022 at 4:05 PM Richard Biener wrote: > > > > > > The following refactors profitable_path_p in the backward threader, > > > spl

Re: [PATCH] Refactor back_threader_profitability

2022-08-17 Thread Richard Biener via Gcc-patches
On Wed, 17 Aug 2022, Aldy Hernandez wrote: > I just have a few high level comments. > > On Tue, Aug 16, 2022 at 4:05 PM Richard Biener wrote: > > > > The following refactors profitable_path_p in the backward threader, > > splitting out parts that can be computed once the exit block is known, > >

Re: [PATCH] Refactor back_threader_profitability

2022-08-17 Thread Aldy Hernandez via Gcc-patches
I just have a few high level comments. On Tue, Aug 16, 2022 at 4:05 PM Richard Biener wrote: > > The following refactors profitable_path_p in the backward threader, > splitting out parts that can be computed once the exit block is known, > parts that contiguously update and that can be checked al