Re: Re: [PATCH] RISC-V: Support highpart register overlap for vwcvt

2023-11-29 Thread 钟居哲
钟居哲; gcc-patches CC: rdapp.gcc; kito.cheng; kito.cheng; Jeff Law Subject: Re: [PATCH] RISC-V: Support highpart register overlap for vwcvt >>> I can't really match spec and code. For the lmul = 2 case sure, >>> but W84 e.g. allows v4 and not v6? What actually is "highes

Re: Re: [PATCH] RISC-V: Support highpart register overlap for vwcvt

2023-11-29 Thread 钟居哲
Jeff Law Subject: Re: [PATCH] RISC-V: Support highpart register overlap for vwcvt >>> I can't really match spec and code. For the lmul = 2 case sure, >>> but W84 e.g. allows v4 and not v6? What actually is "highest-numbered >>> part"? > Yes. > >

Re: [PATCH] RISC-V: Support highpart register overlap for vwcvt

2023-11-29 Thread Robin Dapp
>>> I can't really match spec and code.  For the lmul = 2 case sure, >>> but W84 e.g. allows v4 and not v6?  What actually is "highest-numbered >>>part"? > Yes. > > For vwcvt, LMUL 4 -> LMUL 8.  > We allow overlap  vwcvt v0 (occupy v0 - v7), v4 (occupy v4 - v7) > This patch support the overlap ab

Re: Re: [PATCH] RISC-V: Support highpart register overlap for vwcvt

2023-11-29 Thread 钟居哲
uzhe-Zhong; gcc-patches CC: rdapp.gcc; kito.cheng; kito.cheng; jeffreyalaw Subject: Re: [PATCH] RISC-V: Support highpart register overlap for vwcvt Looks like this already went in while I was looking at it... In general it looks ok to me but I would have really hoped for some more comments. >

Re: [PATCH] RISC-V: Support highpart register overlap for vwcvt

2023-11-29 Thread Robin Dapp
Looks like this already went in while I was looking at it... In general it looks ok to me but I would have really hoped for some more comments. > +;; These following constraints are used by RVV instructions with dest EEW > > src EEW. > +;; RISC-V 'V' Spec 5.2. Vector Operands: > +;; The destinat

Re: [PATCH] RISC-V: Support highpart register overlap for vwcvt

2023-11-29 Thread Kito Cheng
OK, thanks for moving that forward! but just one nit: don't include godbolt.org url as possible since it's not permanently valid. On Wed, Nov 29, 2023 at 4:36 PM juzhe.zh...@rivai.ai wrote: > > Sorry for sending it twice. > > Add > > Co-authored-by: kito-cheng > Co-authored-by: kito-cheng > >

Re: [PATCH] RISC-V: Support highpart register overlap for vwcvt

2023-11-29 Thread juzhe.zh...@rivai.ai
Sorry for sending it twice. Add Co-authored-by: kito-cheng Co-authored-by: kito-cheng in changelog. No other difference. juzhe.zh...@rivai.ai From: Juzhe-Zhong Date: 2023-11-29 16:34 To: gcc-patches CC: kito.cheng; kito.cheng; jeffreyalaw; rdapp.gcc; Juzhe-Zhong Subject: [PATCH] RISC-V: Supp