Re: [PATCH] RISC-V: Refactor and cleanup fma patterns

2023-09-19 Thread Lehua Ding
Hi Patrick and Robin, I fixed this ICE by this patch (https://gcc.gnu.org/pipermail/gcc-patches/2023-September/630969.html). I didn't repeat this problem at first because I was using -O0 compiled GCC. It reappeared after it was changed to -O2. Sorry for introducing this problem, and thanks a

Re: [PATCH] RISC-V: Refactor and cleanup fma patterns

2023-09-19 Thread Lehua Ding
Hi Patrick and Robin, Thanks for reporting, I'll fix this as soon as I can. On 2023/9/20 05:53, Robin Dapp wrote: Hi Patrick, thanks for reporting. Before seeing your message here I already opened a PR https://gcc.gnu.org/bugzilla/show_bug.cgi?id=111488 Regards Robin -- Best, Lehua

Re: [PATCH] RISC-V: Refactor and cleanup fma patterns

2023-09-19 Thread Robin Dapp
Hi Patrick, thanks for reporting. Before seeing your message here I already opened a PR https://gcc.gnu.org/bugzilla/show_bug.cgi?id=111488 Regards Robin

Re: [PATCH] RISC-V: Refactor and cleanup fma patterns

2023-09-18 Thread Lehua Ding
Committed, thanks Juzhe. On 2023/9/19 11:10, juzhe.zh...@rivai.ai wrote: Thanks for the refactoring. This patch is needed in VLS fma support and undefined value enabling support. LGTM. juzhe.zh...@rivai.ai *From:*

Re: [PATCH] RISC-V: Refactor and cleanup fma patterns

2023-09-18 Thread juzhe.zh...@rivai.ai
Thanks for the refactoring. This patch is needed in VLS fma support and undefined value enabling support. LGTM. juzhe.zh...@rivai.ai From: Lehua Ding Date: 2023-09-18 19:37 To: gcc-patches CC: juzhe.zhong; kito.cheng; rdapp.gcc; palmer; jeffreyalaw; lehua.ding Subject: [PATCH] RISC-V: Refact