Re: [PATCH] RISC-V: Fixed failed rvv combine testcases

2023-11-07 Thread Lehua Ding
Hi Robin, On 2023/11/7 15:57, Robin Dapp wrote: Thanks, what I was slightly concerned about is that we now have the implicit assumption that the initial value is 0. I mean that's what the vectorizer does for reductions but theoretically, wouldn't we also combine other values into 0 now? Sorry

Re: [PATCH] RISC-V: Fixed failed rvv combine testcases

2023-11-06 Thread Robin Dapp
Thanks, what I was slightly concerned about is that we now have the implicit assumption that the initial value is 0. I mean that's what the vectorizer does for reductions but theoretically, wouldn't we also combine other values into 0 now? Regards Robin

Re: [PATCH] RISC-V: Fixed failed rvv combine testcases

2023-11-06 Thread Lehua Ding
Committed, thanks Juzhe. On 2023/11/7 15:51, juzhe.zh...@rivai.ai wrote: LGTM. Thanks for fixing it. juzhe.zh...@rivai.ai *From:* Lehua Ding *Date:* 2023-11-07 15:49 *To:* gcc-patc

Re: [PATCH] RISC-V: Fixed failed rvv combine testcases

2023-11-06 Thread juzhe.zh...@rivai.ai
LGTM. Thanks for fixing it. juzhe.zh...@rivai.ai From: Lehua Ding Date: 2023-11-07 15:49 To: gcc-patches CC: juzhe.zhong; kito.cheng; rdapp.gcc; palmer; jeffreyalaw; lehua.ding Subject: [PATCH] RISC-V: Fixed failed rvv combine testcases Hi, This patch fixed the fellowing failed testcases on