Re: [PATCH] RISC-V: Add sign-extending variants for vmv.x.s.

2023-06-12 Thread Jeff Law via Gcc-patches
On 6/12/23 09:15, 钟居哲 wrote: Change +(define_insn "@pred_extract_first_sextdi" into (define_insn "*pred_extract_first_sextdi" Change +(define_insn "@pred_extract_first_sextsi" into (define_insn "*pred_extract_first_sextsi" I don't think we will call combine pattern in vector-opt.md in th

Re: [PATCH] RISC-V: Add sign-extending variants for vmv.x.s.

2023-06-12 Thread Robin Dapp via Gcc-patches
> Change  > > +(define_insn "@pred_extract_first_sextdi" > > into  > > (define_insn "*pred_extract_first_sextdi" Yeah, I was thinking about this as well right after sending. We will probably never call this directly. Regards Robin

Re: [PATCH] RISC-V: Add sign-extending variants for vmv.x.s.

2023-06-12 Thread 钟居哲
Change +(define_insn "@pred_extract_first_sextdi" into (define_insn "*pred_extract_first_sextdi" Change +(define_insn "@pred_extract_first_sextsi" into (define_insn "*pred_extract_first_sextsi" I don't think we will call combine pattern in vector-opt.md in the future. Use "*" instead of "@" can