Re: [PATCH] RISC-V: Add avail interface into function_group_info

2023-12-07 Thread Kito Cheng
> #ifndef DEF_RVV_FUNCTION > -#define DEF_RVV_FUNCTION(NAME, SHAPE, PREDS, OPS_INFO) > +#define DEF_RVV_FUNCTION(NAME, SHAPE, PREDS, OPS_INFO, AVAIL) #define DEF_RVV_FUNCTION(NAME, SHAPE, PREDS, OPS_INFO, ...) And add a comment to mention 5th argument is optional for AVAIL. > #endif > > /* In

Re: Re: [PATCH] RISC-V: Add avail interface into function_group_info

2023-12-07 Thread Feng Wang
2023-12-07 20:23 juzhe.zhong wrote: >Thanks for doing this! > >+AVAIL (always, true) >-> AVAIL (true, true) > >+DEF_RVV_FUNCTION (vmul, alu, full_preds, iu_vvv_ops, always) >-> DEF_RVV_FUNCTION (vmul, alu, full_preds, iu_vvv_ops, true) > >Btw, we have full coverage rvv -

Re: [PATCH] RISC-V: Add avail interface into function_group_info

2023-12-07 Thread juzhe.zh...@rivai.ai
Also add avail.h into: riscv-vector-builtins.o: $(srcdir)/config/riscv/riscv-vector-builtins.cc \   $(CONFIG_H) $(SYSTEM_H) coretypes.h $(TM_H) $(TREE_H) $(RTL_H) $(TM_P_H) \   memmodel.h insn-codes.h $(OPTABS_H) $(RECOG_H) $(DIAGNOSTIC_H) $(EXPR_H) \   $(FUNCTION_H) fold-const.h gimplify.h explow