Re: [PATCH] Prune invalid filename due to makefile syntax.

2020-01-23 Thread Nathan Sidwell
On 1/23/20 4:54 AM, Martin Liška wrote: On 1/22/20 9:12 AM, Richard Biener wrote: Ah, maybe it's worth to export this functionality to libiberty? That would make sense to me. Can you please Nathan factor out the function to libiberty? you're not the boss of me :) But seriously, I'm not real

Re: [PATCH] Prune invalid filename due to makefile syntax.

2020-01-23 Thread Martin Liška
On 1/22/20 9:12 AM, Richard Biener wrote: Ah, maybe it's worth to export this functionality to libiberty? That would make sense to me. Can you please Nathan factor out the function to libiberty? Thanks, Martin

Re: [PATCH] Prune invalid filename due to makefile syntax.

2020-01-22 Thread Richard Biener
On Tue, Jan 21, 2020 at 5:40 PM Nathan Sidwell wrote: > > On 1/21/20 11:26 AM, Richard Biener wrote: > > On January 21, 2020 4:37:00 PM GMT+01:00, Jan Hubicka > > wrote: > > >> I would say we want to fix that... Even GCC gets idea to put # info > >> filenames and I am sure except for HHVM there

Re: [PATCH] Prune invalid filename due to makefile syntax.

2020-01-21 Thread Nathan Sidwell
On 1/21/20 11:26 AM, Richard Biener wrote: On January 21, 2020 4:37:00 PM GMT+01:00, Jan Hubicka wrote: I would say we want to fix that... Even GCC gets idea to put # info filenames and I am sure except for HHVM there are others. Can't w just quote them somehow? IIUC there are two issues

Re: [PATCH] Prune invalid filename due to makefile syntax.

2020-01-21 Thread Richard Biener
On January 21, 2020 4:37:00 PM GMT+01:00, Jan Hubicka wrote: >> On 1/21/20 4:08 PM, Jan Hubicka wrote: >> > I think this is not enough - you need to take into consideration >all >> > special characters used by make and bash, such as $ and others... >> >> Hm, you are right. Do you have a reasonabl

Re: [PATCH] Prune invalid filename due to makefile syntax.

2020-01-21 Thread Jan Hubicka
> On 1/21/20 4:08 PM, Jan Hubicka wrote: > > I think this is not enough - you need to take into consideration all > > special characters used by make and bash, such as $ and others... > > Hm, you are right. Do you have a reasonable list which we should support? No - I guess one needs to dig into m

Re: [PATCH] Prune invalid filename due to makefile syntax.

2020-01-21 Thread Martin Liška
On 1/21/20 4:08 PM, Jan Hubicka wrote: I think this is not enough - you need to take into consideration all special characters used by make and bash, such as $ and others... Hm, you are right. Do you have a reasonable list which we should support? Or should we leave this known limitation? Mart

Re: [PATCH] Prune invalid filename due to makefile syntax.

2020-01-21 Thread Martin Liška
On 1/21/20 4:15 PM, Andreas Schwab wrote: On Jan 21 2020, Martin Liška wrote: diff --git a/gcc/lto-wrapper.c b/gcc/lto-wrapper.c index fe8f292f877..f2504cc5b4f 100644 --- a/gcc/lto-wrapper.c +++ b/gcc/lto-wrapper.c @@ -1241,6 +1241,16 @@ jobserver_active_p (void) && is_valid_fd (wfd))

Re: [PATCH] Prune invalid filename due to makefile syntax.

2020-01-21 Thread Andreas Schwab
On Jan 21 2020, Martin Liška wrote: > diff --git a/gcc/lto-wrapper.c b/gcc/lto-wrapper.c > index fe8f292f877..f2504cc5b4f 100644 > --- a/gcc/lto-wrapper.c > +++ b/gcc/lto-wrapper.c > @@ -1241,6 +1241,16 @@ jobserver_active_p (void) > && is_valid_fd (wfd)); > } > > +/* Prune invalid char

Re: [PATCH] Prune invalid filename due to makefile syntax.

2020-01-21 Thread Jan Hubicka
> Hi. > > The patch strips '#' in filenames used for Makefile. > > Ready to be installed? > Thanks, > Martin > > gcc/ChangeLog: > > 2020-01-21 Martin Liska > > PR driver/93057 > * lto-wrapper.c (prune_filename_for_make): Prune > characters like '#'. I think this is not en