Re: Fwd: Re: [PATCH] Postpone __LINE__ evaluation to the end of #line directives

2013-11-28 Thread Joseph S. Myers
On Thu, 28 Nov 2013, Max Woodbury wrote: > As for the sequence of comments you point to, they are discussing the > use of __LINE__ in macros, not directives. The standard is quite a bit > more explicit about token substitution in directives, making it fairly > clear that substitution is not to oc

Fwd: Re: [PATCH] Postpone __LINE__ evaluation to the end of #line directives

2013-11-28 Thread Max Woodbury
Original Message Subject: Re: [PATCH] Postpone __LINE__ evaluation to the end of #line directives Date: Thu, 28 Nov 2013 17:32:41 -0500 From: Max Woodbury To: Joseph S. Myers On 11/28/2013 11:34 AM, Joseph S. Myers wrote: On Wed, 27 Nov 2013, Max Woodbury wrote: There

Re: [PATCH] Postpone __LINE__ evaluation to the end of #line directives

2013-11-28 Thread Joseph S. Myers
On Wed, 27 Nov 2013, Max Woodbury wrote: > There should be a way to change the __FILE__ value without changing the > line number sequencing. Whatever that mechanism is, it should NOT > introduce maintenance problems that involve counting lines of code. I think that #line is mainly intended for u

Re: [PATCH] Postpone __LINE__ evaluation to the end of #line directives

2013-11-27 Thread Max Woodbury
On 11/27/2013 04:10 PM, Joseph S. Myers wrote: On further consideration, I'm not convinced there's a bug here at all; I don't think it's sufficiently defined in the standard what the current token is for the purposes of line numbering when __LINE__ gets expanded to be able to say that one or the

Re: [PATCH] Postpone __LINE__ evaluation to the end of #line directives

2013-11-27 Thread Joseph S. Myers
On further consideration, I'm not convinced there's a bug here at all; I don't think it's sufficiently defined in the standard what the current token is for the purposes of line numbering when __LINE__ gets expanded to be able to say that one or the other value in a directive is wrong. As far

Re: [PATCH] Postpone __LINE__ evaluation to the end of #line directives

2013-11-27 Thread Joseph S. Myers
On Wed, 27 Nov 2013, Max Woodbury wrote: > On 11/27/2013 05:46 AM, Marek Polacek wrote:> On Wed, Nov 27, 2013 at > 05:29:22AM -0500, mtewoodb...@gmail.com wrote: > >> From: Max TenEyck Woodbury > > > > This patch is badly missing a description. You also want to mention > > the PR number, if this

Re: [PATCH] Postpone __LINE__ evaluation to the end of #line directives

2013-11-27 Thread Max Woodbury
On 11/27/2013 05:46 AM, Marek Polacek wrote:> On Wed, Nov 27, 2013 at 05:29:22AM -0500, mtewoodb...@gmail.com wrote: >> From: Max TenEyck Woodbury > > This patch is badly missing a description. You also want to mention > the PR number, if this fixes a bug. I guess this is to fix PR58687. > I

Re: [PATCH] Postpone __LINE__ evaluation to the end of #line directives

2013-11-27 Thread Max Woodbury
From 6c95593f684c120a0ea7ef6178401283f63250b7 Mon Sep 17 00:00:00 2001 From: Max TenEyck Woodbury Date: Sun, 24 Nov 2013 09:48:09 -0500 Subject: [PATCH] Postpone __LINE__ evaluation to the end of #line directives To: gcc-patches@gcc.gnu.org Copyright 2013 assigned to the Free Software Foundation

Re: [PATCH] Postpone __LINE__ evaluation to the end of #line directives

2013-11-27 Thread Joseph S. Myers
On Wed, 27 Nov 2013, mtewoodb...@gmail.com wrote: > Copyright 2013 assigned to the Free Software Foundation. FWIW I don't see this in copyright.list yet. If you sent the paperwork (whether paper mail or scans) to the FSF over a week ago and haven't had it acknowledged, please chase up ass...@g

Re: [PATCH] Postpone __LINE__ evaluation to the end of #line directives

2013-11-27 Thread Marek Polacek
On Wed, Nov 27, 2013 at 05:29:22AM -0500, mtewoodb...@gmail.com wrote: > From: Max TenEyck Woodbury This patch is badly missing a description. You also want to mention the PR number, if this fixes a bug. I guess this is to fix PR58687. > Copyright 2013 assigned to the Free Software Foundation