Re: [PATCH] PR88777, Out-of-range offsets building glibc test-tgmath2.c

2019-06-03 Thread Jeff Law
On 1/11/19 4:44 PM, Alan Modra wrote: > On Fri, Jan 11, 2019 at 11:42:31AM -0700, Jeff Law wrote: >> On 1/10/19 12:19 AM, Alan Modra wrote: >>> bb-reorder is quite seriously broken if get_attr_min_length should >>> return INT_MAX, which it does for hppa on branches with r267666. >> Presumably you'r

Re: [PATCH] PR88777, Out-of-range offsets building glibc test-tgmath2.c

2019-01-11 Thread Alan Modra
On Fri, Jan 11, 2019 at 07:49:54PM +, Richard Sandiford wrote: > FWIW, I think this is papering over a deeper issue, Most certainly. At the very least there's the fact that many places in the compiler that call attr_min_value (via other functions) don't bother checking for an INT_MAX return.

Re: [PATCH] PR88777, Out-of-range offsets building glibc test-tgmath2.c

2019-01-11 Thread Alan Modra
On Fri, Jan 11, 2019 at 11:42:31AM -0700, Jeff Law wrote: > On 1/10/19 12:19 AM, Alan Modra wrote: > > bb-reorder is quite seriously broken if get_attr_min_length should > > return INT_MAX, which it does for hppa on branches with r267666. > Presumably you're referring to the overflows and such? Ye

Re: [PATCH] PR88777, Out-of-range offsets building glibc test-tgmath2.c

2019-01-11 Thread Richard Sandiford
Jeff Law writes: > On 1/10/19 12:19 AM, Alan Modra wrote: >> bb-reorder is quite seriously broken if get_attr_min_length should >> return INT_MAX, which it does for hppa on branches with r267666. > Presumably you're referring to the overflows and such? > > >> >> I went the wrong way with my min_a

Re: [PATCH] PR88777, Out-of-range offsets building glibc test-tgmath2.c

2019-01-11 Thread Jeff Law
On 1/10/19 12:19 AM, Alan Modra wrote: > bb-reorder is quite seriously broken if get_attr_min_length should > return INT_MAX, which it does for hppa on branches with r267666. Presumably you're referring to the overflows and such? > > I went the wrong way with my min_attr_value r267666 change. I