Re: [PATCH] PR82964: Fix 128-bit immediate ICEs

2018-01-18 Thread Wilco Dijkstra
Christophe Lyon wrote: > After this patch (r256800), I have noticed new failures on aarch64: >    gcc.target/aarch64/f16_mov_immediate_1.c scan-assembler-times > mov\tw[0-9]+, #?19520 3 (found 0 times) Thanks for spotting these, the scripts appear to have missed those (contrib/dg-cmp-results.sh s

Re: [PATCH] PR82964: Fix 128-bit immediate ICEs

2018-01-18 Thread Christophe Lyon
Hi Wilco, On 17 January 2018 at 17:22, Wilco Dijkstra wrote: > James Greenhalgh wrote: > >> - /* Do not allow wide int constants - this requires support in movti. */ >> + /* Only allow simple 128-bit immediates. */ >>if (CONST_WIDE_INT_P (x)) >> -return false; >> +return aarch64_

Re: [PATCH] PR82964: Fix 128-bit immediate ICEs

2018-01-17 Thread Wilco Dijkstra
James Greenhalgh wrote: > -  /* Do not allow wide int constants - this requires support in movti.  */ > +  /* Only allow simple 128-bit immediates.  */ >    if (CONST_WIDE_INT_P (x)) > -    return false; > +    return aarch64_mov128_immediate (x); > I can see why this could be correct, but it is

Re: [PATCH] PR82964: Fix 128-bit immediate ICEs

2018-01-16 Thread James Greenhalgh
On Mon, Jan 15, 2018 at 11:34:19AM +, Wilco Dijkstra wrote: > This fixes PR82964 which reports ICEs for some CONST_WIDE_INT immediates. > It turns out decimal floating point CONST_DOUBLE get changed into > CONST_WIDE_INT without checking the constraint on the operand, which > results in failur