On Sun, Oct 11, 2015 at 6:07 AM, Alan Modra wrote:
>
> gcc/
> * config/rs6000/sysv4.h (TARGET_CAN_SPLIT_STACK_64BIT): Don't define.
> * config/rs6000/linux64.h (TARGET_CAN_SPLIT_STACK): Define.
> (TARGET_CAN_SPLIT_STACK_64BIT): Define.
> gcc/go/
> * gospec.c (saw_op
Alan said he did this, which was a bootstrap and regression test of
all the combinations:
/I built four configurations, powerpc-linux 32-bit only,
powerpc64le-linux 64-bit only, biarch powerpc-linux with 32-bit default,
and biarch powerpc64-linux with 64-bit default/
I also did verify that on
On Sun, Oct 11, 2015 at 9:07 AM, Alan Modra wrote:
> On Sat, Oct 10, 2015 at 11:25:38PM +0200, Andreas Schwab wrote:
>> "Lynn A. Boger" writes:
>>
>> > Index: gcc/config/rs6000/sysv4.h
>> > ===
>> > --- gcc/config/rs6000/sysv4.h
On 13.10.2015 00:53, Alan Modra wrote:
On Mon, Oct 12, 2015 at 10:15:04AM -0500, Lynn A. Boger wrote:
Thanks for doing this Alan. I agree this looks better to me.
I assume by "etc" you mean you did biarch builds for your bootstraps on BE?
By "etc" I meant "and regression tested".
I built fo
On Mon, Oct 12, 2015 at 10:15:04AM -0500, Lynn A. Boger wrote:
> Thanks for doing this Alan. I agree this looks better to me.
>
> I assume by "etc" you mean you did biarch builds for your bootstraps on BE?
By "etc" I meant "and regression tested".
I built four configurations, powerpc-linux 32-b
Thanks for doing this Alan. I agree this looks better to me.
I assume by "etc" you mean you did biarch builds for your bootstraps on BE?
On 10/11/2015 08:07 AM, Alan Modra wrote:
On Sat, Oct 10, 2015 at 11:25:38PM +0200, Andreas Schwab wrote:
"Lynn A. Boger" writes:
Index: gcc/config/rs600
On Sun, Oct 11, 2015 at 11:29:36AM -0700, Ian Lance Taylor wrote:
> On Sun, Oct 11, 2015 at 7:43 AM, Andreas Schwab wrote
> >
> > Please remind me why this logic isn't implemented as a target hook.
> >
> > supports_split_stack = TARGET_CAN_SPLIT_STACK;
> >
> > /* rs6000.h */
> > #define TARGET_CAN
On Sun, Oct 11, 2015 at 7:43 AM, Andreas Schwab wrote
>
> Please remind me why this logic isn't implemented as a target hook.
>
> supports_split_stack = TARGET_CAN_SPLIT_STACK;
>
> /* rs6000.h */
> #define TARGET_CAN_SPLIT_STACK TARGET_64BIT
There is a target hook for split stack support in
gcc/c
Alan Modra writes:
> diff --git a/gcc/go/gospec.c b/gcc/go/gospec.c
> index ca3c2d7..fbb55be 100644
> --- a/gcc/go/gospec.c
> +++ b/gcc/go/gospec.c
> @@ -120,8 +120,10 @@ lang_specific_driver (struct cl_decoded_option
> **in_decoded_options,
>/* Whether the -S option was used. */
>bool
On Sat, Oct 10, 2015 at 11:25:38PM +0200, Andreas Schwab wrote:
> "Lynn A. Boger" writes:
>
> > Index: gcc/config/rs6000/sysv4.h
> > ===
> > --- gcc/config/rs6000/sysv4.h (revision 228653)
> > +++ gcc/config/rs6000/sysv4.h
"Lynn A. Boger" writes:
> Index: gcc/config/rs6000/sysv4.h
> ===
> --- gcc/config/rs6000/sysv4.h (revision 228653)
> +++ gcc/config/rs6000/sysv4.h (working copy)
> @@ -940,13 +940,15 @@ ncrtn.o%s"
> #undef TARGET_ASAN_SHADOW_OFFSET
On 10.10.2015 16:00, David Edelsohn wrote:
On Fri, Oct 9, 2015 at 3:51 PM, Lynn A. Boger
wrote:
Here's a new one.
Tried all the variations, verified that split stack is still enabled and
uses gold linker for 64 bit targets
when using a 64 bit default compiler, and does not give the split stack
On Fri, Oct 9, 2015 at 3:51 PM, Lynn A. Boger
wrote:
> Here's a new one.
>
> Tried all the variations, verified that split stack is still enabled and
> uses gold linker for 64 bit targets
> when using a 64 bit default compiler, and does not give the split stack
> error for 32 bit default
> compile
Here's a new one.
Tried all the variations, verified that split stack is still enabled and
uses gold linker for 64 bit targets
when using a 64 bit default compiler, and does not give the split stack
error for 32 bit default
compilers.
On 10/08/2015 03:46 PM, Matthias Klose wrote:
On 08.10.20
On 08.10.2015 20:56, Lynn A. Boger wrote:
I think my original fix with linux.h doing the #undef on
TARGET_CAN_SPLIT_STACK_64BIT is the right fix at least
for powerpc-linux-gnu 32 bit only.
It works for powerpc-linux-gnu without multilib and doesn't break
powerpc64-linux-gnu or powerpc64le-linux-
I think my original fix with linux.h doing the #undef on
TARGET_CAN_SPLIT_STACK_64BIT is the right fix at least
for powerpc-linux-gnu 32 bit only.
It works for powerpc-linux-gnu without multilib and doesn't break
powerpc64-linux-gnu or powerpc64le-linux-gnu.
Can you tell me how you are config
On Wed, Oct 7, 2015 at 3:37 PM, Lynn A. Boger
wrote:
> Right I didn't think of the multilib on powerpc-linux-gnu (actually didn't
> think that was allowed).
>
> I don't think TARGET_64BIT will work here (I tried it), because on ppc64 &
> ppc64le it gets replaced with a code snippet to check
> a va
On 07.10.2015 17:36, Lynn A. Boger wrote:
Pretty sure this is the fix, but still doing some testing.
linux.h isn't included for multilib enabled builds defaulting to
powerpc-linux-gnu, I am currently testing
--- gcc/config/rs6000/sysv4.h (revision 228571)
+++ gcc/config/rs6000/sysv4.h (w
On Wed, Oct 7, 2015 at 1:04 PM, Ian Lance Taylor wrote:
> On Wed, Oct 7, 2015 at 8:36 AM, Lynn A. Boger
> wrote:
>> Pretty sure this is the fix, but still doing some testing.
>
> Looks good to me but I suppose David E. should approve.
It's fine with me. Thanks for fixing this.
Thanks, David
On Wed, Oct 7, 2015 at 8:36 AM, Lynn A. Boger
wrote:
> Pretty sure this is the fix, but still doing some testing.
Looks good to me but I suppose David E. should approve.
Ian
On 01.10.2015 01:07, Ian Lance Taylor wrote:
On Thu, Sep 17, 2015 at 12:13 PM, Lynn A. Boger
wrote:
Here is my updated patch, with the changes suggested by
Ian for gcc/gospec.c and David for gcc/configure.ac.
Bootstrap built and tested on ppc64le, ppc64 multilib.
2015-09-17Lynn Boger
gcc
On Thu, Sep 17, 2015 at 12:13 PM, Lynn A. Boger
wrote:
> Here is my updated patch, with the changes suggested by
> Ian for gcc/gospec.c and David for gcc/configure.ac.
>
> Bootstrap built and tested on ppc64le, ppc64 multilib.
>
> 2015-09-17Lynn Boger
> gcc/
> PR target/66870
>
Any update on this patch?
On 09/18/2015 07:48 AM, David Edelsohn wrote:
On Thu, Sep 17, 2015 at 3:13 PM, Lynn A. Boger
wrote:
Here is my updated patch, with the changes suggested by
Ian for gcc/gospec.c and David for gcc/configure.ac.
Bootstrap built and tested on ppc64le, ppc64 multilib.
20
On Thu, Sep 17, 2015 at 3:13 PM, Lynn A. Boger
wrote:
> Here is my updated patch, with the changes suggested by
> Ian for gcc/gospec.c and David for gcc/configure.ac.
>
> Bootstrap built and tested on ppc64le, ppc64 multilib.
>
> 2015-09-17Lynn Boger
> gcc/
> PR target/66870
>
Here is my updated patch, with the changes suggested by
Ian for gcc/gospec.c and David for gcc/configure.ac.
Bootstrap built and tested on ppc64le, ppc64 multilib.
2015-09-17Lynn Boger
gcc/
PR target/66870
config/rs6000/sysv4.h: Define TARGET_CAN_SPLIT_STACK_64BIT
On Tue, Sep 15, 2015 at 11:24 AM, Lynn A. Boger
wrote:
>
> I need some feedback on whether to enable the gold linker at
> all for split stack on platforms other than Power in gcc/configure.ac.
> I don't know if there are gold linker versions that should be verified for
> non-Power platforms. My f
I will make the changes Ian suggested to gospec.c and was
planning to fix the sed string in gcc/configure.ac as David suggested.
I need some feedback on whether to enable the gold linker at
all for split stack on platforms other than Power in gcc/configure.ac.
I don't know if there are gold linke
On Thu, Aug 27, 2015 at 5:00 PM, Lynn A. Boger
wrote:
> Here is an updated patch, with a summary of the differences from my previous
> patch:
>
> - In my previous patch gcc configure was verifying the gold linker even if
> it was the
> default linker, but that is not necessary since in that case -
On Thu, Aug 27, 2015 at 2:00 PM, Lynn A. Boger
wrote:
> Here is an updated patch, with a summary of the differences from my previous
> patch:
>
> - In my previous patch gcc configure was verifying the gold linker even if
> it was the
> default linker, but that is not necessary since in that case -
Here is an updated patch, with a summary of the differences from my previous
patch:
- In my previous patch gcc configure was verifying the gold linker even
if it was the
default linker, but that is not necessary since in that case
-fuse-ld=gold does not
need to be set. Gold version checking is
I am working on a new patch to address some of the previous concerns
and plan to post it soon after some final testing.
On 08/25/2015 05:51 PM, Ian Lance Taylor wrote:
On Tue, Aug 18, 2015 at 1:36 PM, Lynn A. Boger
wrote:
libgo/
PR target/66870
configure.ac: When gccgo for b
On Tue, Aug 18, 2015 at 1:36 PM, Lynn A. Boger
wrote:
>
> libgo/
> PR target/66870
> configure.ac: When gccgo for building libgo uses the gold version
> containing split stack support on ppc64, ppc64le, define
> LINKER_SUPPORTS_SPLIT_STACK.
> configure: Re
Also, I don't think it is sufficient to add the option to enable the
gold linker in gospec.c. That will only affect links when using gccgo.
You also want to use the gold linker with gcc if -fsplit-stack is used.
That is why I had to add it to a spec in linux64.h, so that -fuse-ld=gold
is added i
The split stack support only recently went into the gold
linker for Power so the configure needs to detect if the
gold linker version contains that support. If the build tries
to use a gold linker without that support the build
will fail on Power. My understanding was that the gold
linker suppo
On Wed, Aug 19, 2015 at 3:33 PM, Matthias Klose wrote:
> why keep the old behaviour for other archs that have split stack support? Is
> it
> really necessary to make this dependent on the target? I'm still using an
> unreviewed/unpinged patch to enable gold for gccgo (attached).
I much prefer y
On 08/18/2015 10:36 PM, Lynn A. Boger wrote:
> As discussed in PR 66870, for ppc64le and ppc64le it is preferred to
> use the gold linker with gccgo or gcc if the split stack option is enabled.
> Use of the gold linker with the split stack option results in less storage
> allocated for goroutine s
36 matches
Mail list logo
