Re: [PATCH] PR libstdc++/80316 make promise::set_value throw no_state error

2017-07-12 Thread Christophe Lyon
On 12 July 2017 at 12:15, Jonathan Wakely wrote: > On 12/07/17 09:46 +0200, Christophe Lyon wrote: >> >> On 11 July 2017 at 14:39, Jonathan Wakely wrote: >>> >>> On 11/07/17 12:53 +0100, Jonathan Wakely wrote: On 21/04/17 15:54 +0100, Jonathan Wakely wrote: > > > On 4 A

Re: [PATCH] PR libstdc++/80316 make promise::set_value throw no_state error

2017-07-12 Thread Jonathan Wakely
On 12/07/17 09:46 +0200, Christophe Lyon wrote: On 11 July 2017 at 14:39, Jonathan Wakely wrote: On 11/07/17 12:53 +0100, Jonathan Wakely wrote: On 21/04/17 15:54 +0100, Jonathan Wakely wrote: On 4 April 2017 at 20:44, Jonathan Wakely wrote: We got a bug report from a customer pointing ou

Re: [PATCH] PR libstdc++/80316 make promise::set_value throw no_state error

2017-07-12 Thread Christophe Lyon
On 11 July 2017 at 14:39, Jonathan Wakely wrote: > On 11/07/17 12:53 +0100, Jonathan Wakely wrote: >> >> On 21/04/17 15:54 +0100, Jonathan Wakely wrote: >>> >>> On 4 April 2017 at 20:44, Jonathan Wakely wrote: We got a bug report from a customer pointing out that calling promise::se

Re: [PATCH] PR libstdc++/80316 make promise::set_value throw no_state error

2017-07-11 Thread Jonathan Wakely
On 11/07/17 12:53 +0100, Jonathan Wakely wrote: On 21/04/17 15:54 +0100, Jonathan Wakely wrote: On 4 April 2017 at 20:44, Jonathan Wakely wrote: We got a bug report from a customer pointing out that calling promise::set_value on a moved-from promise crashes instead of throwing an exception with

Re: [PATCH] PR libstdc++/80316 make promise::set_value throw no_state error

2017-07-11 Thread Jonathan Wakely
On 21/04/17 15:54 +0100, Jonathan Wakely wrote: On 4 April 2017 at 20:44, Jonathan Wakely wrote: We got a bug report from a customer pointing out that calling promise::set_value on a moved-from promise crashes instead of throwing an exception with error code future_errc::no_state. This fixes it

Re: [PATCH] PR libstdc++/80316 make promise::set_value throw no_state error

2017-04-21 Thread Jonathan Wakely
On 4 April 2017 at 20:44, Jonathan Wakely wrote: > We got a bug report from a customer pointing out that calling > promise::set_value on a moved-from promise crashes instead of throwing > an exception with error code future_errc::no_state. > > This fixes it, by moving the _S_check calls to *before*