Re: [PATCH] PR libgcc/83112, Fix warnings on libgcc float128-ifunc.c

2017-12-13 Thread Segher Boessenkool
On Tue, Dec 12, 2017 at 04:56:36PM -0500, Michael Meissner wrote: > On Tue, Dec 12, 2017 at 11:04:55AM -0600, Segher Boessenkool wrote: > > On Mon, Dec 11, 2017 at 03:57:51PM -0500, Michael Meissner wrote: > > > > > +extern KCtype __divkc3 (KFtype, KFtype, KFtype, KFtype); > > > > > + > > > > > KC

Re: [PATCH] PR libgcc/83112, Fix warnings on libgcc float128-ifunc.c

2017-12-12 Thread Michael Meissner
On Tue, Dec 12, 2017 at 11:04:55AM -0600, Segher Boessenkool wrote: > On Mon, Dec 11, 2017 at 03:57:51PM -0500, Michael Meissner wrote: > > > > +extern KCtype __divkc3 (KFtype, KFtype, KFtype, KFtype); > > > > + > > > > KCtype > > > > __divkc3 (KFtype a, KFtype b, KFtype c, KFtype d) > > > > { >

Re: [PATCH] PR libgcc/83112, Fix warnings on libgcc float128-ifunc.c

2017-12-12 Thread Andreas Schwab
On Dez 12 2017, Segher Boessenkool wrote: > On Mon, Dec 11, 2017 at 03:57:51PM -0500, Michael Meissner wrote: >> > > +extern KCtype __divkc3 (KFtype, KFtype, KFtype, KFtype); >> > > + >> > > KCtype >> > > __divkc3 (KFtype a, KFtype b, KFtype c, KFtype d) >> > > { >> > >> > How does this warn?

Re: [PATCH] PR libgcc/83112, Fix warnings on libgcc float128-ifunc.c

2017-12-12 Thread Segher Boessenkool
On Mon, Dec 11, 2017 at 03:57:51PM -0500, Michael Meissner wrote: > > > +extern KCtype __divkc3 (KFtype, KFtype, KFtype, KFtype); > > > + > > > KCtype > > > __divkc3 (KFtype a, KFtype b, KFtype c, KFtype d) > > > { > > > > How does this warn? -Wmissing-declarations? Should this declaration be

Re: [PATCH] PR libgcc/83112, Fix warnings on libgcc float128-ifunc.c

2017-12-11 Thread Michael Meissner
On Fri, Dec 01, 2017 at 05:53:55PM -0600, Segher Boessenkool wrote: > On Fri, Dec 01, 2017 at 12:40:22AM -0500, Michael Meissner wrote: > > After committing the previous patch, I noticed that it was now generating > > warnings for __{mul,div}kc3_{sw,hw} not having a prototype that I hadn't > > noti

Re: [PATCH] PR libgcc/83112, Fix warnings on libgcc float128-ifunc.c

2017-12-01 Thread Segher Boessenkool
On Fri, Dec 01, 2017 at 12:40:22AM -0500, Michael Meissner wrote: > After committing the previous patch, I noticed that it was now generating > warnings for __{mul,div}kc3_{sw,hw} not having a prototype that I hadn't > noticed during development of the patch. This is due to the fact that before >

Re: [PATCH] PR libgcc/83112, Fix warnings on libgcc float128-ifunc.c

2017-11-30 Thread Michael Meissner
After committing the previous patch, I noticed that it was now generating warnings for __{mul,div}kc3_{sw,hw} not having a prototype that I hadn't noticed during development of the patch. This is due to the fact that before I added the ifunc support, it was only compiling __{mul,div}kc3, and those

Re: [PATCH] PR libgcc/83112, Fix warnings on libgcc float128-ifunc.c

2017-11-30 Thread Michael Meissner
On Wed, Nov 29, 2017 at 08:42:51PM -0600, Segher Boessenkool wrote: > Hi, > > On Mon, Nov 27, 2017 at 06:40:09PM -0500, Michael Meissner wrote: > > @@ -33,3 +35,13 @@ $(fp128_hw_obj) : $(srcdir)/config/rs6 > > > > $(fp128_ifunc_obj) : INTERNAL_CFLAGS += $(FP128_CFLAGS_SW) > > $(fp12

Re: [PATCH] PR libgcc/83112, Fix warnings on libgcc float128-ifunc.c

2017-11-29 Thread Segher Boessenkool
Hi, On Mon, Nov 27, 2017 at 06:40:09PM -0500, Michael Meissner wrote: > @@ -33,3 +35,13 @@ $(fp128_hw_obj) : $(srcdir)/config/rs6 > > $(fp128_ifunc_obj): INTERNAL_CFLAGS += $(FP128_CFLAGS_SW) > $(fp128_ifunc_obj): $(srcdir)/config/rs6000/t-float128-hw > + > +_mulkc3-hw.c: $

Re: [PATCH] PR libgcc/83112, Fix warnings on libgcc float128-ifunc.c

2017-11-27 Thread Michael Meissner
On Mon, Nov 27, 2017 at 03:40:58PM -0700, Martin Sebor wrote: > On 11/27/2017 12:21 PM, Michael Meissner wrote: > >The new -Wattribute-alias option now issues warnings for old-style ifunc > >declarations that coerce the pointer to the function to void *. The > >float128-ifunc.c module in libgcc/co

Re: [PATCH] PR libgcc/83112, Fix warnings on libgcc float128-ifunc.c

2017-11-27 Thread Martin Sebor
On 11/27/2017 12:21 PM, Michael Meissner wrote: The new -Wattribute-alias option now issues warnings for old-style ifunc declarations that coerce the pointer to the function to void *. The float128-ifunc.c module in libgcc/config/rs6000 now gets a lot of warnings of the form: ../float128-ifunc.