Re: [PATCH] PR debug/77315 - use DW_OP_form_tls_address

2016-10-21 Thread Jakub Jelinek
On Fri, Oct 21, 2016 at 02:38:11PM -0600, Tom Tromey wrote: > > "Jakub" == Jakub Jelinek writes: > > Jakub> Also, as this effectively requires the latest unreleased GDB under the > Jakub> default options for something that has been working previously, I > wonder > Jakub> if it e.g. for some

Re: [PATCH] PR debug/77315 - use DW_OP_form_tls_address

2016-10-21 Thread Tom Tromey
> "Jakub" == Jakub Jelinek writes: Jakub> Also, as this effectively requires the latest unreleased GDB under the Jakub> default options for something that has been working previously, I wonder Jakub> if it e.g. for some time shouldn't be guarded with dwarf_version >= 5 Here's what that looks

Re: [PATCH] PR debug/77315 - use DW_OP_form_tls_address

2016-10-21 Thread Tom Tromey
> "Jakub" == Jakub Jelinek writes: Jakub> I admit I haven't looked at the GDB changes, but how will the debugger know Jakub> if it is an emutls emulation or normal ELF TLS, if the same op is used Jakub> in both cases? Because gdb never implemented DW_OP_form_tls_address, that emultls case h

Re: [PATCH] PR debug/77315 - use DW_OP_form_tls_address

2016-10-21 Thread Jakub Jelinek
On Fri, Oct 21, 2016 at 11:17:33AM -0600, Tom Tromey wrote: > This patch changes gcc to emit DW_OP_form_tls_address rather than > DW_OP_GNU_push_tls_address. This is PR debug/77315. > > DW_OP_form_tls_address was added in DWARF 3, and this patch uses the > DWARF version to decide which opcode to