Re: [PATCH] Optional alternative base_expr in finding basis for CAND_REFs

2013-11-26 Thread Yufeng Zhang
On 11/26/13 12:45, Richard Biener wrote: On Thu, Nov 14, 2013 at 12:25 AM, Yufeng Zhang wrote: Hi Bill, On 11/13/13 20:54, Bill Schmidt wrote: Hi Yufeng, The second version of your original patch is ok with me with the following changes. Sorry for the little side adventure into the next-i

Re: [PATCH] Optional alternative base_expr in finding basis for CAND_REFs

2013-11-26 Thread Richard Biener
On Thu, Nov 14, 2013 at 12:25 AM, Yufeng Zhang wrote: > Hi Bill, > > > On 11/13/13 20:54, Bill Schmidt wrote: >> >> Hi Yufeng, >> >> The second version of your original patch is ok with me with the >> following changes. Sorry for the little side adventure into the >> next-interp logic; in the end

Re: [PATCH] Optional alternative base_expr in finding basis for CAND_REFs

2013-11-13 Thread Yufeng Zhang
Hi Bill, On 11/13/13 20:54, Bill Schmidt wrote: Hi Yufeng, The second version of your original patch is ok with me with the following changes. Sorry for the little side adventure into the next-interp logic; in the end that's going to hurt more than it helps in this case. Thanks for having a l

Re: [PATCH] Optional alternative base_expr in finding basis for CAND_REFs

2013-11-13 Thread Bill Schmidt
Hi Yufeng, The second version of your original patch is ok with me with the following changes. Sorry for the little side adventure into the next-interp logic; in the end that's going to hurt more than it helps in this case. Thanks for having a look at it, anyway. Thanks also for cleaning up thi

Re: [PATCH] Optional alternative base_expr in finding basis for CAND_REFs

2013-11-13 Thread Bill Schmidt
Hi Yufeng, On Wed, 2013-11-13 at 19:32 +, Yufeng Zhang wrote: > Hi Bill, > > On 11/13/13 18:04, Bill Schmidt wrote: > > Hi Yufeng, > > > > On Tue, 2013-11-12 at 22:34 +, Yufeng Zhang wrote: > >> Hi Bill, > >> > >> Many thanks for the review. > >> > >> I find your suggestion on using the n

Re: [PATCH] Optional alternative base_expr in finding basis for CAND_REFs

2013-11-13 Thread Yufeng Zhang
Hi Bill, On 11/13/13 18:04, Bill Schmidt wrote: Hi Yufeng, On Tue, 2013-11-12 at 22:34 +, Yufeng Zhang wrote: Hi Bill, Many thanks for the review. I find your suggestion on using the next_interp field quite enlightening. I prepared a patch which adds changes without modifying the framew

Re: [PATCH] Optional alternative base_expr in finding basis for CAND_REFs

2013-11-13 Thread Bill Schmidt
Hi Yufeng, On Tue, 2013-11-12 at 22:34 +, Yufeng Zhang wrote: > Hi Bill, > > Many thanks for the review. > > I find your suggestion on using the next_interp field quite > enlightening. I prepared a patch which adds changes without modifying > the framework. With the patch, the slsr pass

Re: [PATCH] Optional alternative base_expr in finding basis for CAND_REFs

2013-11-12 Thread Yufeng Zhang
Hi Bill, Many thanks for the review. I find your suggestion on using the next_interp field quite enlightening. I prepared a patch which adds changes without modifying the framework. With the patch, the slsr pass now tries to create a second candidate for each memory accessing gimple stateme

Re: [PATCH] Optional alternative base_expr in finding basis for CAND_REFs

2013-11-11 Thread Bill Schmidt
Hi Yufeng, The idea is a good one but I don't like your implementation of adding an extra expression parameter to look at on the find_basis_for_candidate lookup. This goes against the design of the pass and may not be sufficiently general (might there be situations where a third possible basis co