Re: [PATCH] New IPA-CP with real function cloning - updated version

2011-07-15 Thread Jan Hubicka
> Thanks, however, I'm not confident committing this on Friday when I'm > going to be offline until Monday noon :-) Moreover, I already have a I will be flying back to Europe, so you even can't push responsibility to me :) > newer version that should handle aliases to thunks. The changes since >

Re: [PATCH] New IPA-CP with real function cloning

2011-07-15 Thread Martin Jambor
Hi, On Thu, Jul 14, 2011 at 11:28:32PM +0200, Jan Hubicka wrote: > > > > Well, technically they survive until after inlining (because of > > indirect inlining which also derives information from the lattices > > corresponding to node->inlined_to node. Results of arithmetic > > functions are not

Re: [PATCH] New IPA-CP with real function cloning - updated version

2011-07-14 Thread Jan Hubicka
> 2011-07-14 Martin Jambor > > * ipa-prop.h: Include alloc-pool.h, all sorts of updates to general > comments. > (ipcp_values_pool): Declare. > (ipcp_sources_pool): Likewise. > (ipcp_lattice): Changed to forward declaration. > (ipa_param_descriptor): Removed

Re: [PATCH] New IPA-CP with real function cloning

2011-07-14 Thread Jan Hubicka
> > Well, technically they survive until after inlining (because of > indirect inlining which also derives information from the lattices > corresponding to node->inlined_to node. Results of arithmetic > functions are not going to be accessed during inlining when compiling > any reasonable program

Re: [PATCH] New IPA-CP with real function cloning

2011-07-14 Thread Jan Hubicka
> > > if (dec < cs->count) > > > cs->count -= dec; > > > else > > > cs->count = 0; > > > } > > > > > > if (dump_file) > > > dump_profile_updates (orig_node, new_node); > > > } > > > > > > if (node->local.can_change_signature) > > > { > > > args_to_skip = BITM

Re: [PATCH] New IPA-CP with real function cloning

2011-07-14 Thread Martin Jambor
Hi, like with the previous mail, I'll reply to the comments here and then post a new version of the patch in a separate thread. On Sun, Jul 10, 2011 at 07:04:21PM +0200, Jan Hubicka wrote: > > > > /* If checking is enabled, verify that no lattice is in the TOP state, i.e. > > not > >bottom,

Re: [PATCH] New IPA-CP with real function cloning

2011-07-14 Thread Martin Jambor
Hi, I'll send a new version of IPA-CP incorporating most of the feedback in a new thread but let me also comment on some of the points here: On Fri, Jul 08, 2011 at 08:24:31PM +0200, Jan Hubicka wrote: > > > > { > > > > /* Pointer to an array of structures describing individual formal > > > >

Re: [PATCH] New IPA-CP with real function cloning

2011-07-10 Thread Jan Hubicka
> > /* If checking is enabled, verify that no lattice is in the TOP state, i.e. > not >bottom, not containing a variable component and without any known value at >the same time. */ > > static void > verify_propagated_values (void) > { > #ifdef ENABLE_CHECKING Hmm, would not be better t

Re: [PATCH] New IPA-CP with real function cloning

2011-07-08 Thread Jan Hubicka
> > > /* Structure holding data required to describe a pass-through jump > > > function. */ > > > > > > struct GTY(()) ipa_pass_through_data > > > { > > > /* If an operation is to be performed on the original parameter, this > > > is the > > > second (constant) operand. */ > > > tree

Re: [PATCH] New IPA-CP with real function cloning

2011-07-08 Thread Martin Jambor
Hi, On Thu, Jul 07, 2011 at 06:03:07PM +0200, Jan Hubicka wrote: > Hi, > patch is long, so let me review it in more passes. Fair enough. > > > > > > 2011-06-22 Martin Jambor > > > > * ipa-prop.h: Include alloc-pool.h. > > (ipa_lattice_type): Removed. > > (ipcp_value_source): Ne

Re: [PATCH] New IPA-CP with real function cloning

2011-07-07 Thread Jan Hubicka
Hi, patch is long, so let me review it in more passes. > > > 2011-06-22 Martin Jambor > > * ipa-prop.h: Include alloc-pool.h. > (ipa_lattice_type): Removed. > (ipcp_value_source): New type. > (ipcp_value): Likewise. > (ipcp_values_pool): Declare. > (ipcp_so