Re: [PATCH] Make warn_inline Optimization option.

2020-01-13 Thread Richard Biener
On Mon, Jan 13, 2020 at 9:47 AM Martin Liška wrote: > > Hi. > > I've got a patch that restores --help=optimize to what we had for GCC 9. > That means it will not print parameters (and the warn_inline warning). > > Patch can bootstrap on x86_64-linux-gnu and survives regression tests. > > Ready to

Re: [PATCH] Make warn_inline Optimization option.

2020-01-13 Thread Martin Liška
Hi. I've got a patch that restores --help=optimize to what we had for GCC 9. That means it will not print parameters (and the warn_inline warning). Patch can bootstrap on x86_64-linux-gnu and survives regression tests. Ready to be installed? Thanks, Martin >From 44870c6ac7e97a36cbd0ca102bbe73ab

Re: [PATCH] Make warn_inline Optimization option.

2020-01-08 Thread Jan Hubicka
On unrelated note, looking what we print with --verbose -v The following options are specific to just the language LTO: -flinker-output=Set linker output type (used internally during LTO optimization). -fltransRun the link-time optimizer in local transformatio

Re: [PATCH] Make warn_inline Optimization option.

2020-01-08 Thread Richard Biener
On Wed, Jan 8, 2020 at 11:22 AM Jan Hubicka wrote: > > > > > Given all warning options can be enabled/disabled via #pragma GCC > > > > diagnostic > > > > all Warning annotated options should be implicitely 'Optimization' for > > > > the purpose > > > > of LTO streaming then? > > > > > > Well, per

Re: [PATCH] Make warn_inline Optimization option.

2020-01-08 Thread Martin Liška
On 1/8/20 12:08 PM, Jan Hubicka wrote: Hmm, indeed. Well, I belive we use the 'Optimization' flag for other purposes than only triggering LTO streaming and option save/restore, so we need another flag that only triggers save/restore then (and also allow us to avoid dropping the flag at lto-optio

Re: [PATCH] Make warn_inline Optimization option.

2020-01-08 Thread Jan Hubicka
> Hmm, indeed. Well, I belive we use the 'Optimization' flag for other purposes > than only triggering LTO streaming and option save/restore, so we need another > flag that only triggers save/restore then (and also allow us to avoid > dropping the > flag at lto-option streaming time where we curre

Re: [PATCH] Make warn_inline Optimization option.

2020-01-08 Thread Jan Hubicka
> > > Given all warning options can be enabled/disabled via #pragma GCC > > > diagnostic > > > all Warning annotated options should be implicitely 'Optimization' for > > > the purpose > > > of LTO streaming then? > > > > Well, perhaps they can be marked but for late optimizations this does > > not

Re: [PATCH] Make warn_inline Optimization option.

2020-01-08 Thread Richard Biener
On Tue, Jan 7, 2020 at 4:46 PM Jan Hubicka wrote: > > > On Tue, Jan 7, 2020 at 3:26 PM Jan Hubicka wrote: > > > > > > > Err - Optimization also lists it in some -help section? It's a Warning > > > > option and certainly we don't handle per-function Warnings in general > > > > (with LTO) even tho

Re: [PATCH] Make warn_inline Optimization option.

2020-01-07 Thread Jan Hubicka
> On Tue, Jan 7, 2020 at 3:26 PM Jan Hubicka wrote: > > > > > Err - Optimization also lists it in some -help section? It's a Warning > > > option and certainly we don't handle per-function Warnings in general > > > (with LTO) even though we have #pragma GCC diagnostic, no? > > > > > > I'm not sur

Re: [PATCH] Make warn_inline Optimization option.

2020-01-07 Thread Richard Biener
On Tue, Jan 7, 2020 at 3:26 PM Jan Hubicka wrote: > > > Err - Optimization also lists it in some -help section? It's a Warning > > option and certainly we don't handle per-function Warnings in general > > (with LTO) even though we have #pragma GCC diagnostic, no? > > > > I'm not sure why we force

Re: [PATCH] Make warn_inline Optimization option.

2020-01-07 Thread Jan Hubicka
> Err - Optimization also lists it in some -help section? It's a Warning > option and certainly we don't handle per-function Warnings in general > (with LTO) even though we have #pragma GCC diagnostic, no? > > I'm not sure why we force warn_inline to zero with -O0, it seems much > better to guard

Re: [PATCH] Make warn_inline Optimization option.

2020-01-07 Thread Richard Biener
On Thu, Jan 2, 2020 at 10:04 AM Martin Liška wrote: > > Hi. > > The patch is about using Optimization for warn_inline as > it's affected by -O0. > > Patch can bootstrap on x86_64-linux-gnu and survives regression tests. > > Ready to be installed? Err - Optimization also lists it in some -help sec

Re: [PATCH] Make warn_inline Optimization option.

2020-01-06 Thread Jeff Law
On Thu, 2020-01-02 at 10:04 +0100, Martin Liška wrote: > Hi. > > The patch is about using Optimization for warn_inline as > it's affected by -O0. > > Patch can bootstrap on x86_64-linux-gnu and survives regression tests. > > Ready to be installed? > Thanks, > Martin > > gcc/ChangeLog: > > 2019